Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags with special characters #262

Closed
dcramer opened this issue Apr 6, 2020 · 4 comments · Fixed by #291
Closed

Flags with special characters #262

dcramer opened this issue Apr 6, 2020 · 4 comments · Fixed by #291
Labels
bug

Comments

@dcramer
Copy link

dcramer commented Apr 6, 2020

Describe the bug
Adding a flag with a : character breaks the UI. e.g. foo:bar
@dcramer dcramer added the bug label Apr 6, 2020
@markphelps
Copy link
Collaborator

Thanks for reporting @dcramer. I'll work on this ASAP

@markphelps
Copy link
Collaborator

Confirmed. GRPC Gateway issue here that I believe is causing this: grpc-ecosystem/grpc-gateway#224

@stale
Copy link

stale bot commented May 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 19, 2020
@markphelps
Copy link
Collaborator

Not stale, currently working on it

@stale stale bot removed the stale label May 20, 2020
@markphelps markphelps mentioned this issue May 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow colons flipt-io/flipt
2 participants
@dcramer @markphelps