Add zero poly tests to other mpolys

Jake Moss · Jake Moss · commit 27c25e9b95eb · 2024-10-01T14:52:23.000+10:00
diff --git a/src/fmpq_mpoly/test/t-compose_fmpq_mpoly.c b/src/fmpq_mpoly/test/t-compose_fmpq_mpoly.c
@@ -17,13 +17,15 @@ TEST_FUNCTION_START(fmpq_mpoly_compose_fmpq_mpoly, state)
     slong i, j, v;
 
     {
-        fmpq_mpoly_t A, A1, A2, B;
+        slong nvarsAC = 2, nvarsB = 3;
+        fmpq_mpoly_t A, A1, A2, B, B1;
         fmpq_mpoly_struct * Cp[3];
         fmpq_mpoly_struct C[3];
         fmpq_mpoly_ctx_t ctxAC, ctxB;
+        slong * c;
 
-        fmpq_mpoly_ctx_init(ctxB, 3, ORD_LEX);
-        fmpq_mpoly_ctx_init(ctxAC, 2, ORD_LEX);
+        fmpq_mpoly_ctx_init(ctxB, nvarsB, ORD_LEX);
+        fmpq_mpoly_ctx_init(ctxAC, nvarsAC, ORD_LEX);
 
         fmpq_mpoly_init(B, ctxB);
         fmpq_mpoly_init(A, ctxAC);
@@ -70,11 +72,47 @@ TEST_FUNCTION_START(fmpq_mpoly_compose_fmpq_mpoly, state)
             fflush(stdout);
             flint_abort();
         }
+        /* Aliased generator composition */
+        c = (slong *) flint_malloc(nvarsB*sizeof(slong));
+        fmpq_mpoly_init(B1, ctxB);
+        fmpq_mpoly_set(B1, B, ctxB);
+        for (i = 0; i < nvarsB; i++)
+            c[i] = i;
+
+        fmpq_mpoly_compose_fmpq_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (!fmpq_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with aliased generators\n");
+
+        /* Reverse the generators, twice */
+        for (i = 0; i < nvarsB; i++)
+            c[i] = nvarsB - i - 1;
+
+        fmpq_mpoly_compose_fmpq_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (fmpq_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with reversed aliased generators\n");
+
+        fmpq_mpoly_compose_fmpq_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (!fmpq_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with un-reversed aliased generators\n");
+
+        /* Composition with zero polys */
+        fmpq_mpoly_zero(B1, ctxB);
+
+        fmpq_mpoly_compose_fmpq_mpoly_gen(A, B1, c, ctxB, ctxAC);
+        if (!fmpq_mpoly_is_zero(B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with generators of zero poly\n");
+
+        fmpq_mpoly_set_str_pretty(C + 0, "2*x1", NULL, ctxAC);
+        fmpq_mpoly_set_str_pretty(C + 1, "x2", NULL, ctxAC);
+        fmpq_mpoly_set_str_pretty(C + 2, "1", NULL, ctxAC);
+        if (!fmpq_mpoly_compose_fmpq_mpoly(A, B1, Cp, ctxB, ctxAC))
+            TEST_FUNCTION_FAIL("Check example 4\n");
+
+        if (!fmpq_mpoly_is_zero(A, ctxAC))
+            TEST_FUNCTION_FAIL("Check composition with zero poly\n");
 
         fmpq_mpoly_clear(B, ctxB);
         fmpq_mpoly_clear(A, ctxAC);
-        fmpq_mpoly_clear(A1, ctxAC);
-        fmpq_mpoly_clear(A2, ctxAC);
         for (i = 0; i < 3; i++)
             fmpq_mpoly_clear(C + i, ctxAC);
 
diff --git a/src/fmpz_mpoly/test/t-compose_fmpz_mpoly.c b/src/fmpz_mpoly/test/t-compose_fmpz_mpoly.c
@@ -17,13 +17,15 @@ TEST_FUNCTION_START(fmpz_mpoly_compose_fmpz_mpoly, state)
     slong i, j, v;
 
     {
-        fmpz_mpoly_t A, A1, A2, B;
+        slong nvarsAC = 2, nvarsB = 3;
+        fmpz_mpoly_t A, A1, A2, B, B1;
         fmpz_mpoly_struct * Cp[3];
         fmpz_mpoly_struct C[3];
         fmpz_mpoly_ctx_t ctxAC, ctxB;
+        slong * c;
 
-        fmpz_mpoly_ctx_init(ctxB, 3, ORD_LEX);
-        fmpz_mpoly_ctx_init(ctxAC, 2, ORD_LEX);
+        fmpz_mpoly_ctx_init(ctxB, nvarsB, ORD_LEX);
+        fmpz_mpoly_ctx_init(ctxAC, nvarsAC, ORD_LEX);
 
         fmpz_mpoly_init(B, ctxB);
         fmpz_mpoly_init(A, ctxAC);
@@ -77,6 +79,49 @@ TEST_FUNCTION_START(fmpz_mpoly_compose_fmpz_mpoly, state)
             flint_abort();
         }
 
+        /* Aliased generator composition */
+        c = (slong *) flint_malloc(nvarsB*sizeof(slong));
+        fmpz_mpoly_init(B1, ctxB);
+        fmpz_mpoly_set(B1, B, ctxB);
+        for (i = 0; i < nvarsB; i++)
+            c[i] = i;
+
+        fmpz_mpoly_compose_fmpz_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (!fmpz_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with aliased generators\n");
+
+        /* Reverse the generators, twice */
+        for (i = 0; i < nvarsB; i++)
+            c[i] = nvarsB - i - 1;
+
+        fmpz_mpoly_compose_fmpz_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (fmpz_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with reversed aliased generators\n");
+
+        fmpz_mpoly_compose_fmpz_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (!fmpz_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with un-reversed aliased generators\n");
+
+        /* Composition with zero polys */
+        fmpz_mpoly_zero(B1, ctxB);
+
+        fmpz_mpoly_compose_fmpz_mpoly_gen(A, B1, c, ctxB, ctxAC);
+        if (!fmpz_mpoly_is_zero(B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with generators of zero poly\n");
+
+        fmpz_mpoly_set_str_pretty(C + 0, "2*x1", NULL, ctxAC);
+        fmpz_mpoly_set_str_pretty(C + 1, "x2", NULL, ctxAC);
+        fmpz_mpoly_set_str_pretty(C + 2, "1", NULL, ctxAC);
+        if (!fmpz_mpoly_compose_fmpz_mpoly(A, B1, Cp, ctxB, ctxAC) ||
+            !fmpz_mpoly_compose_fmpz_mpoly_horner(A1, B1, Cp, ctxB, ctxAC) ||
+            !fmpz_mpoly_compose_fmpz_mpoly_geobucket(A2, B1, Cp, ctxB, ctxAC))
+            TEST_FUNCTION_FAIL("Check example 4\n");
+
+        if (!fmpz_mpoly_is_zero(A, ctxAC) ||
+            !fmpz_mpoly_is_zero(A1, ctxAC) ||
+            !fmpz_mpoly_is_zero(A2, ctxAC))
+            TEST_FUNCTION_FAIL("Check composition with zero poly\n");
+
         fmpz_mpoly_clear(B, ctxB);
         fmpz_mpoly_clear(A, ctxAC);
         fmpz_mpoly_clear(A1, ctxAC);
diff --git a/src/nmod_mpoly/test/t-compose_nmod_mpoly.c b/src/nmod_mpoly/test/t-compose_nmod_mpoly.c
@@ -18,13 +18,15 @@ TEST_FUNCTION_START(nmod_mpoly_compose_nmod_mpoly, state)
     slong i, j, v;
 
     {
-        nmod_mpoly_t A, A1, A2, B;
+        slong nvarsAC = 2, nvarsB = 3;
+        nmod_mpoly_t A, A1, A2, B, B1;
         nmod_mpoly_struct * Cp[3];
         nmod_mpoly_struct C[3];
         nmod_mpoly_ctx_t ctxAC, ctxB;
+        slong * c;
 
-        nmod_mpoly_ctx_init(ctxB, 3, ORD_LEX, 13);
-        nmod_mpoly_ctx_init(ctxAC, 2, ORD_LEX, 13);
+        nmod_mpoly_ctx_init(ctxB, nvarsB, ORD_LEX, 13);
+        nmod_mpoly_ctx_init(ctxAC, nvarsAC, ORD_LEX, 13);
 
         nmod_mpoly_init(B, ctxB);
         nmod_mpoly_init(A, ctxAC);
@@ -78,6 +80,49 @@ TEST_FUNCTION_START(nmod_mpoly_compose_nmod_mpoly, state)
             flint_abort();
         }
 
+        /* Aliased generator composition */
+        c = (slong *) flint_malloc(nvarsB*sizeof(slong));
+        nmod_mpoly_init(B1, ctxB);
+        nmod_mpoly_set(B1, B, ctxB);
+        for (i = 0; i < nvarsB; i++)
+            c[i] = i;
+
+        nmod_mpoly_compose_nmod_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (!nmod_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with aliased generators\n");
+
+        /* Reverse the generators, twice */
+        for (i = 0; i < nvarsB; i++)
+            c[i] = nvarsB - i - 1;
+
+        nmod_mpoly_compose_nmod_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (nmod_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with reversed aliased generators\n");
+
+        nmod_mpoly_compose_nmod_mpoly_gen(B1, B1, c, ctxB, ctxB);
+        if (!nmod_mpoly_equal(B, B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with un-reversed aliased generators\n");
+
+        /* Composition with zero polys */
+        nmod_mpoly_zero(B1, ctxB);
+
+        nmod_mpoly_compose_nmod_mpoly_gen(A, B1, c, ctxB, ctxAC);
+        if (!nmod_mpoly_is_zero(B1, ctxB))
+            TEST_FUNCTION_FAIL("Check composition with generators of zero poly\n");
+
+        nmod_mpoly_set_str_pretty(C + 0, "2*x1", NULL, ctxAC);
+        nmod_mpoly_set_str_pretty(C + 1, "x2", NULL, ctxAC);
+        nmod_mpoly_set_str_pretty(C + 2, "1", NULL, ctxAC);
+        if (!nmod_mpoly_compose_nmod_mpoly(A, B1, Cp, ctxB, ctxAC) ||
+            !nmod_mpoly_compose_nmod_mpoly_horner(A1, B1, Cp, ctxB, ctxAC) ||
+            !nmod_mpoly_compose_nmod_mpoly_geobucket(A2, B1, Cp, ctxB, ctxAC))
+            TEST_FUNCTION_FAIL("Check example 4\n");
+
+        if (!nmod_mpoly_is_zero(A, ctxAC) ||
+            !nmod_mpoly_is_zero(A1, ctxAC) ||
+            !nmod_mpoly_is_zero(A2, ctxAC))
+            TEST_FUNCTION_FAIL("Check composition with zero poly\n");
+
         nmod_mpoly_clear(B, ctxB);
         nmod_mpoly_clear(A, ctxAC);
         nmod_mpoly_clear(A1, ctxAC);
