Skip to content

Substitution builder #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 72 commits into from
Closed

Substitution builder #1566

wants to merge 72 commits into from

Conversation

@lockshaw
Copy link
Collaborator

@lockshaw lockshaw commented Jan 2, 2025 •
edited by wmdi
Loading

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

This change is Reviewable

lockshaw added 30 commits June 3, 2024 21:04
@lockshaw
Start on pcg builder
510c2d9
@lockshaw
Add tests and some implementation for pcg builder
7b55ed1
@lockshaw
Add pcg tests, make dtgen constructors explicit to fix bug
c379efd
@lockshaw
Add remainder of PCG tests
35fa653
@lockshaw
Merge remote-tracking branch 'origin/repo-refactor' into pcg-builder
865a28e
@lockshaw
Fix build issues in local-execution
f379539
@lockshaw
Format
2dbb3b9
@lockshaw
Address Reyna comments, add topological_order function for PCG
4050c99
@lockshaw
Pre multidigraph refactor
42c1968
@lockshaw
Removing visitable from sp code
3be816f
@lockshaw
Add open dataflow graph, start to replace pcg dataflow graph
6d68324
@lockshaw
Start refactoring substitutions
64a3403
@lockshaw
Add utility functions to support pattern matching
7d4c7be
@lockshaw
Pre-refactor inputs
9ab9eb2
@lockshaw
Merge remote-tracking branch 'origin/repo-refactor' into dataflow-graph
7ae7c65
@lockshaw
Fix proj url
f9b129e
@lockshaw
Get back to substitutions, now with unordered graph inputs
cf73f08
@lockshaw
Get substitutions building
5fd666d
@lockshaw
substitutions-tests now builds
5f0c88a
@lockshaw
Fix bug in filter, pass some initial substitution tests
3228f2d
@lockshaw
Add tests for fmt::to_string, fix some substitutions bugs
5f4cc01
@lockshaw
Pass initial unit tests for find_pattern_matches
ad60be0
@lockshaw
Start on unit tests for pcg pattern
a972da2
@lockshaw
Pass initial test for find_pattern_matches
bcf776e
@lockshaw
Merge remote-tracking branch 'origin/repo-refactor' into dataflow-graph
e28400e
@lockshaw
Fix small build issue in tests
fe6d65d
@lockshaw
Format
e647af7
@lockshaw
Sync tests in CI with tests in proj
8b58760
@lockshaw
Fix minor build errors in kernels and local-execution
1fafb9d
@lockshaw
Format
0804314
lockshaw added 28 commits July 24, 2024 17:47
@lockshaw
Add implementations and tests for applying series/parallel reductions
267b72d
@lockshaw
Format
bb2769a
@lockshaw
Clean up sp decomposition interface and tests
39cb7b3
@lockshaw
Format
ce0234d
@lockshaw
Add comments for top-level substitutions functions, add proj doxygen …
3dc3ec6 
…support
@lockshaw
Start sketching out substitutions code
ee518c2
@lockshaw
Merge branch 'dataflow-graph' into substitutions-fix
f69b95a
@lockshaw
Fix build errors
3c06b88
@lockshaw
Add ability to permute node ids
3d6f681
@lockshaw
Cleanup and start to test new substitutions code
098a9d1
@lockshaw
Add test case for evaluate_substitution_output
9bd4f14
@lockshaw
Add naive isomorphism detection code
101083b
@lockshaw
Add graph inputs to open dataflow graph isomorphism
9fec50c
@lockshaw
Add input permutation to evaluate_substitution_output
7c60736
@lockshaw
Fix permute_node_ids
cb6eab2
@lockshaw
Add test for permute_input_ids
2f3d67a
@lockshaw
Migrate over to mutable implementation of apply_substitution
03cbd02
@lockshaw
Add fast isomorphism checking and an initial implementation of full s…
4a8deae 
…ubstitution logic
@lockshaw
Pass initial full substitutions test
0757e94
@lockshaw
Cleanup old isomorphism checking code
ba0a174
@lockshaw
Merge remote-tracking branch 'origin/repo-refactor' into substitution…
4dfa403 
…s-fix
@lockshaw
Fix post-merge bugs
f156f96
@lockshaw
Fix broken pcg builder test
5f09298
@lockshaw
Format
deff4f8
@lockshaw
Reorganize code and remove some outdated code pre-code-review
d71d24f
@lockshaw
Format
1a63f90
@lockshaw
Restarting work on this after working on export-model-arch
1d4ab09
@lockshaw
Merge remote-tracking branch 'flexflow/repo-refactor' into substituti…
7928864 
…on-builder
@lockshaw
Copy link
Collaborator Author

lockshaw commented Feb 1, 2025

Closed in favor of #1575.

@lockshaw lockshaw closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lockshaw