From 2c04413fa366cdc061e73e8b96d871a737e80327 Mon Sep 17 00:00:00 2001 From: Jacob Shandling Date: Mon, 24 Mar 2025 09:30:07 -0700 Subject: [PATCH 01/23] remove Fleet URL validation on settings page --- .../cards/WebAddress/WebAddress.tsx | 23 +------------------ 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/frontend/pages/admin/OrgSettingsPage/cards/WebAddress/WebAddress.tsx b/frontend/pages/admin/OrgSettingsPage/cards/WebAddress/WebAddress.tsx index f18a9b594826..deab84282fd4 100644 --- a/frontend/pages/admin/OrgSettingsPage/cards/WebAddress/WebAddress.tsx +++ b/frontend/pages/admin/OrgSettingsPage/cards/WebAddress/WebAddress.tsx @@ -3,7 +3,6 @@ import React, { useState } from "react"; import Button from "components/buttons/Button"; // @ts-ignore import InputField from "components/forms/fields/InputField"; -import validUrl from "components/forms/validators/valid_url"; import SectionHeader from "components/SectionHeader"; import GitOpsModeTooltipWrapper from "components/GitOpsModeTooltipWrapper"; @@ -13,10 +12,6 @@ interface IWebAddressFormData { serverURL: string; } -interface IWebAddressFormErrors { - server_url?: string | null; -} - const baseClass = "app-config-form"; const WebAddress = ({ @@ -32,22 +27,8 @@ const WebAddress = ({ const { serverURL } = formData; - const [formErrors, setFormErrors] = useState({}); - const onInputChange = ({ name, value }: IFormField) => { setFormData({ ...formData, [name]: value }); - setFormErrors({}); - }; - - const validateForm = () => { - const errors: IWebAddressFormErrors = {}; - if (!serverURL) { - errors.server_url = "Fleet server URL must be present"; - } else if (!validUrl({ url: serverURL, protocols: ["http", "https"] })) { - errors.server_url = `${serverURL} is not a valid URL`; - } - - setFormErrors(errors); }; const onFormSubmit = (evt: React.MouseEvent) => { @@ -79,8 +60,6 @@ const WebAddress = ({ name="serverURL" value={serverURL} parseTarget - onBlur={validateForm} - error={formErrors.server_url} tooltip="The base URL of this instance for use in Fleet links." disabled={gitOpsModeEnabled} /> @@ -90,7 +69,7 @@ const WebAddress = ({