Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move() has two gesture-parameters hasGesture and isUserGesture #280

Closed
johnpryan opened this issue May 17, 2019 · 5 comments
Closed

move() has two gesture-parameters hasGesture and isUserGesture #280

johnpryan opened this issue May 17, 2019 · 5 comments
Labels
feature This issue requests a new feature

Comments

@johnpryan
Copy link
Collaborator

we should combine these
This was referenced May 17, 2019
Closed
Closed
@johnpryan johnpryan added the feature This issue requests a new feature label May 22, 2019
@porn
Copy link

porn commented Jul 4, 2019

what is the difference between the two then?

@johnpryan
Copy link
Collaborator Author

none, AFAICT. just bad API management :)

@wmcshane
Copy link
Contributor

I'm going to remove isUserGesture and submit a pull request. I originally added it as hasGesture wasn't handle all scenarios as expected, however, it's since been fixed.

@johnpryan
Copy link
Collaborator Author

@wmcshane thanks!

@maRci002
Copy link
Contributor

Solved, see #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue requests a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@porn @johnpryan @maRci002 @wmcshane