Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RichAttributionWidget causes error due to un-mounted setState call #1538

Closed
JaffaKetchup opened this issue May 31, 2023 · 1 comment · Fixed by #1532
Closed

[BUG] RichAttributionWidget causes error due to un-mounted setState call #1538

JaffaKetchup opened this issue May 31, 2023 · 1 comment · Fixed by #1532
Labels
bug This issue reports broken functionality or another error

Comments

@JaffaKetchup
Copy link
Member

What is the bug?

If using RichAttributionWidget with the 'start open, auto close' feature, if the widget/screen containing the widget is unmounted, the RAW still attempts a setState call, which results in an error.

How can we reproduce it?

Use the demonstration code at https://docs.fleaflet.dev/#demonstration. Add another screen to the app, and navigate to this screen within 3 seconds of the map widget being loaded.

Do you have a potential solution?

Check that the RichAttributionWidget is still mounted before calling setState.

Platforms

All

Severity

Erroneous: Prevents normal functioning and causes errors in the console

@JaffaKetchup JaffaKetchup added bug This issue reports broken functionality or another error non-fatal labels May 31, 2023
@JaffaKetchup JaffaKetchup linked a pull request May 31, 2023 that will close this issue
@JaffaKetchup
Copy link
Member Author

Will be fixed by #1532.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant