Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support asymmetric bounds padding #113

Closed
csjames opened this issue Sep 18, 2018 · 5 comments
Closed

Support asymmetric bounds padding #113

csjames opened this issue Sep 18, 2018 · 5 comments
Labels
blocked This issue's resolution can't be worked on right now

Comments

@csjames
Copy link
Contributor

csjames commented Sep 18, 2018

FitBoundsOptions currently takes a Point, perhaps an EdgeInsets would be more appropriate, especially given the parameters name is padding.

Asymmetric padding is supported by Google maps and I believe it is a useful feature

I'll take a look at doing it myself if the boss things the padding looks crap,

Thanks, James :)

@csjames
Copy link
Contributor Author

csjames commented Oct 29, 2018

Bump

@johnpryan
Copy link
Collaborator

thanks for filing an issue. I don't currently have plans to work on this but if you would like to make a PR I agree this would make more sense.

FitBounds options I believe was part of the port from Leaflet

@csjames
Copy link
Contributor Author

csjames commented Oct 29, 2018 via email

@johnpryan johnpryan added the blocked This issue's resolution can't be worked on right now label Nov 19, 2018
@johnpryan
Copy link
Collaborator

Thanks for filing an issue. I went through the PR and nitpicked a few things. If you have time to fix them up I can include them in the next release.

Thanks!

@johnpryan
Copy link
Collaborator

This is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue's resolution can't be worked on right now
Projects
None yet
Development

No branches or pull requests

2 participants