-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support asymmetric bounds padding #113
Labels
blocked
This issue's resolution can't be worked on right now
Comments
Bump |
thanks for filing an issue. I don't currently have plans to work on this but if you would like to make a PR I agree this would make more sense. FitBounds options I believe was part of the port from Leaflet |
I'll get it done, just need a bit of time :)
Thanks!
James
…Sent from my iPhone
On 29 Oct 2018, at 17:48, John Ryan ***@***.***> wrote:
thanks for filing an issue. I don't currently have plans to work on this but if you would like to make a PR I agree this would make more sense.
FitBounds options I believe was part of the port from Leaflet
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks for filing an issue. I went through the PR and nitpicked a few things. If you have time to fix them up I can include them in the next release. Thanks! |
This is fixed now |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FitBoundsOptions currently takes a Point, perhaps an EdgeInsets would be more appropriate, especially given the parameters name is padding.
Asymmetric padding is supported by Google maps and I believe it is a useful feature
I'll take a look at doing it myself if the boss things the padding looks crap,
Thanks, James :)
The text was updated successfully, but these errors were encountered: