Allow using logstash option with the File transport #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the build timed out... Could you please restart it? |
|
+1 |
|
Any news on that? We'd love using it. |
|
+2 |
|
Up Any news on that please? |
|
I've just merged this with a branch I've set up for handling pull requests - hopefully this'll get merged in soon. |
|
are there any updates on this? I see this is now enabled in options if there is work to be done can help out |
|
👍 this will go into the next release for |
|
Cherry-picked as d5ebcb3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed a nice logstash format option by browsing your code, and after reading some PRs I saw you're only using it with another library.
Logging in a file using the logstash format is useful if you use a centralized logstash installation, as we do.
This PR only allows people to add a logstash parameter to format the output, and take advantage of the already written code.
I'm not sure it's useful for the other transports though, so I only added that for the File transport.