Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not appearing as option in Steam #110

Closed
Yaakoss opened this issue Jul 2, 2023 · 14 comments
Closed

Not appearing as option in Steam #110

Yaakoss opened this issue Jul 2, 2023 · 14 comments

Comments

@Yaakoss
Copy link

Yaakoss commented Jul 2, 2023

Fresh install of Debian (today). Steam and SteamTinkerLaunch are the only installed flatpak apps. Nothing has been changed on permissions but SteamtinkerLaunch does not appear in Steam.

@HanPrower
Copy link
Collaborator

Maybe Debian has some weird defaults?

Just try adding it manually with:
flatpak run --command="/app/utils/steamtinkerlaunch/bin/steamtinkerlaunch" --file-forwarding com.valvesoftware.Steam compat add

@Yaakoss
Copy link
Author

Yaakoss commented Jul 2, 2023

it worked :)))))) Thank you very much.

@Yaakoss Yaakoss closed this as completed Jul 2, 2023
@youalreadydid
Copy link

this command also fixed the same issue on Fedora 38

for reference, I manually installed yad (sudo dnf install yad) before, so I'm not sure if you'll need it too.

@sonic2kk
Copy link
Contributor

Sorry to bump a closed issue. Another user recently had to do this as well. Is there anything from my side that can be done about this? It seems like the compat add command is not being executed on Flatpak installation, though STL should be doing it inside of its setflatpak option.

Unless this is distribution-specific? I don't use Flatpak Steam but I did test briefly on my laptop with Arch Linux some time ago, and I didn't have to do anything back then.

@HanPrower
Copy link
Collaborator

HanPrower commented Jul 19, 2023

I actually forgot that STL was running compat add itself when it thought it was in a Flatpak 😅

I was thinking it may be a permission issue and that other OSs (besides Arch, which I use btw) are forcing certain options, but it could just be a weird environment issue and that this statement isn't being met for some people, for some reason (https://github.com/sonic2kk/steamtinkerlaunch/blob/master/steamtinkerlaunch#L23879C1-L23879C81):
if [ -n "$FLATPAK_ID" ] && [ "$FLATPAK_ID" == "com.valvesoftware.Steam" ]; then

It may be worth checking with people who do have the issue, and the fix is to run compat add manually, what their environment variables are.

@HanPrower HanPrower reopened this Jul 19, 2023
@nobodywatchin
Copy link

nobodywatchin commented Jul 28, 2023

This fix worked for me as well on Debian 12, noob question here:

How do I do the same thing but with tinkerlaunch beta?

@sonic2kk
Copy link
Contributor

If you're talking about the Flatpak beta, you'll need to install the Flatpak from the Beta channel.

If you're referring to SteamTinkerLaunch-git, there is no Flatpak build for SteamTinkerLaunch-git. The Flatpak beta channel is not intended to be a SteamTinkerLaunch-git channel. It may be possible to manually replace the STL files in the Flatpak directory with ones cloned from the repo, but that's pretty hacky and is almost certainly not advisable.

There is no official way of using SteamTinkerLaunch-git with Flatpak Steam.

@nobodywatchin
Copy link

I installed it through the flathub beta, I'm wondering if there is a command similar to what @HanPrower posted that can add it manually

@sonic2kk
Copy link
Contributor

Does flatpak run --command="/app/utils/steamtinkerlaunch/bin/steamtinkerlaunch" --file-forwarding com.valvesoftware.Steam compat add not work for the beta?

@nobodywatchin
Copy link

My mistake, it works fine.

@sonic2kk
Copy link
Contributor

sonic2kk commented Aug 11, 2023

Could this be related to the path that STL resolves the Flatpak to when running compat add? There was a PR recently that had to change where some modding tools' .desktop files point to as the realpath was not correct for Flatpak (sonic2kk/steamtinkerlaunch#880).

@HanPrower
Copy link
Collaborator

Could this be related to the path that STL resolves the Flatpak to when running compat add? There was a PR recently that had to change where some modding tools' .desktop files point to as the realpath was not correct for Flatpak (sonic2kk/steamtinkerlaunch#880).

The differing factor is that one command is run inside the sandbox and one is ran outside.

If you run ls on the Flatpak path you get:

flatpak run --command=ls com.valvesoftware.Steam /app/utils/steamtinkerlaunch/bin/
7za         composite  git               git-upload-archive  innoextract    mogrify  pehash  pescan  rsync      steamtinkerlaunch  xwininfo
animate     conjure    git-cvsserver     git-upload-pack     jq             montage  peldd   pesec   rsync-ssl  stream             xxd
cabextract  convert    git-receive-pack  identify            magick         ofs2rva  pepack  pestr   rva2ofs    xdotool            yad
compare     display    git-shell         import              magick-script  pedis    peres   readpe  scalar     xprop

So it exists as expected internally.

However, technically I don't see why running everything with the external variation wouldn't work anyway, and, probably, simply makes more sense...

@LostWarriorr
Copy link

LostWarriorr commented May 29, 2024

Currently having this issue on Debian (KDE Wayland) but also having an additional issue of the command not working due to it not finding xrandr which is interesting. Custom versions of Proton installed through ProtonUp work fine.

flatpak run --command="/app/utils/steamtinkerlaunch/bin/steamtinkerlaunch" --file-forwarding com.valvesoftware.Steam compat add
Wed May 29 10:49:59 AM CDT 2024 ERROR - checkIntDeps - xrandr not found!
Wed May 29 10:49:59 AM CDT 2024 ERROR - checkIntDeps - Above programs need to be installed to use 'steamtinkerlaunch'
Wed May 29 10:49:59 AM CDT 2024 ERROR - checkIntDeps The dependency check can be disabled by enabling 'SKIPINTDEPCHECK' - exiting now

I do have native steam and steamtinkerlaunch already installed and working.

EDIT: I may have some other underlying issue since I can't even run flatpak steam using flatpak run com.valvesoftware.Steam other flatpaks appear to work fine through the commandline

@HanPrower
Copy link
Collaborator

HanPrower commented Jun 21, 2024

So finally got around to properly checking this and it appears that possibly it was never working properly (or if it ever did it broke...). Maybe I misunderstood how the tool was meant to be added to appear correctly and somehow I just ended up with the files elsewhere.

Not sure...

Either way the closing commit above should fix it.

Note that if this fix does work correctly (I did test it, it does seem to work...), you might need to go to your Steam compatibilitytools.d folder and remove the SteamTinkerLaunch folder the command installed:
flatpak run --command="/app/utils/steamtinkerlaunch/bin/steamtinkerlaunch" --file-forwarding com.valvesoftware.Steam compat del

This won't break any settings or anything, just means the tool isn't "physically" installed to the compatibilitytools.d and is instead installed "magically" with merge-dirs (like it was always meant to be!).

The update can take a few hours to appear via flatpak update so if come the 22nd June (UTC+0) the issue persists please let me know! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants