-
Notifications
You must be signed in to change notification settings - Fork 584
[TVM] Rename NDArray -> Tensor
#1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TVM] Rename NDArray -> Tensor
#1651
Conversation
The latest TVM ffi refactor renames `NDArray` to `Tensor`, to align with the terminology in PyTorch. This PR updates flashinfer tvm binding with the rename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @MasterJH5574, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the FlashInfer TVM binding to reflect a recent change in TVM's Foreign Function Interface (FFI), where the NDArray class has been renamed to Tensor. This ensures consistency with TVM's new terminology and PyTorch's conventions, maintaining compatibility with the upstream TVM project.
Highlights
- TVM Binding Update: Renamed
NDArraytoTensorwithin the FlashInfer TVM binding to align with the latest TVM FFI refactor and PyTorch terminology.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
Quick question, how do we specify TVM path for tvm codegen? |
|
with TVM FFI, i think we can further reduce the tvm integration to tvm_ffi path, which is available through tvm_ffi.libinfo, eventually that should fold into the general refactor |
Yes we leave that work to #1641 |
📌 Description
The latest TVM ffi refactor renames
NDArraytoTensor, to align with the terminology in PyTorch. This PR updates flashinfer tvm binding with the rename.apache/tvm#18275
🔍 Related Issues
N/A
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
N/A
Reviewer Notes
N/A