Skip to content

Conversation

@zhyncs
Copy link
Member

@zhyncs zhyncs commented Jun 30, 2025

📌 Description

ref sgl-project/sglang#7621

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @zhyncs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simply updates the version number of the project, likely in preparation for a new release. The change is isolated to the version.txt file.

Highlights

  • Version Bump: The version of the project has been bumped from 0.2.6.post1 to 0.2.7.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the project version to 0.2.7. The change itself is correct. However, a corresponding update to CHANGELOG.md is missing. I've added a review comment to suggest adding a changelog entry for this new version, which is an important practice for keeping users and contributors informed of the changes.

@@ -1 +1 @@
0.2.6.post1
0.2.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

A version bump should be accompanied by a changelog update. Please add an entry for v0.2.7 to CHANGELOG.md detailing the changes since the last release. This is crucial for maintainability and for keeping users informed about what's new in this version.

@yzh119 yzh119 merged commit 4d3fb6d into main Jun 30, 2025
1 of 3 checks passed
@yzh119 yzh119 deleted the zhyncs/027 branch June 30, 2025 19:38
@BBuf
Copy link
Contributor

BBuf commented Jul 1, 2025

After upgrade flashinfer to v2.7.0, I got the error when run test_trtllm_allreduce_fusion.py :

ModuleNotFoundError: No module named 'flashinfer.comm'

With commit 27060628c32e1217e27564adf24e33273f4c8287 , it's ok.

@yzh119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants