Skip to content

Commit 4a80fc4

Browse files
committed
Fix typo
1 parent 41ad558 commit 4a80fc4

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

benchmarks/bench_logging_overhead.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
88
Usage:
99
# Set the logging level before running
10-
export FLASHINFER_APILEVEL=3
10+
export FLASHINFER_LOGLEVEL=3
1111
python bench_logging_overhead.py
1212
1313
# Or run with different levels
14-
FLASHINFER_APILEVEL=0 python bench_logging_overhead.py
15-
FLASHINFER_APILEVEL=1 python bench_logging_overhead.py
16-
FLASHINFER_APILEVEL=3 python bench_logging_overhead.py
17-
FLASHINFER_APILEVEL=5 python bench_logging_overhead.py
14+
FLASHINFER_LOGLEVEL=0 python bench_logging_overhead.py
15+
FLASHINFER_LOGLEVEL=1 python bench_logging_overhead.py
16+
FLASHINFER_LOGLEVEL=3 python bench_logging_overhead.py
17+
FLASHINFER_LOGLEVEL=5 python bench_logging_overhead.py
1818
1919
# Or use the helper script to run all levels
2020
bash benchmark_all_levels.sh
@@ -28,8 +28,8 @@
2828
from typing import List, Tuple
2929

3030
# Get logging level BEFORE importing flashinfer
31-
LOGGING_LEVEL = int(os.environ.get("FLASHINFER_APILEVEL", "0"))
32-
LOG_DEST = os.environ.get("FLASHINFER_APIDEST", "/tmp/flashinfer_benchmark_log.txt")
31+
LOGGING_LEVEL = int(os.environ.get("FLASHINFER_LOGLEVEL", "0"))
32+
LOG_DEST = os.environ.get("FLASHINFER_LOGDEST", "/tmp/flashinfer_benchmark_log.txt")
3333

3434
# Import the decorator
3535
from flashinfer.api_logging import flashinfer_api
@@ -209,8 +209,8 @@ def main():
209209

210210
# Display logging configuration
211211
print("\nLogging Configuration:")
212-
print(f" FLASHINFER_APILEVEL = {LOGGING_LEVEL}")
213-
print(f" FLASHINFER_APIDEST = {LOG_DEST}")
212+
print(f" FLASHINFER_LOGLEVEL = {LOGGING_LEVEL}")
213+
print(f" FLASHINFER_LOGDEST = {LOG_DEST}")
214214

215215
# Get level name
216216
level_names = {
@@ -314,7 +314,7 @@ def main():
314314
print("\nTo benchmark other levels, run:")
315315
for level in [0, 1, 3, 5]:
316316
if level != LOGGING_LEVEL:
317-
print(f" FLASHINFER_APILEVEL={level} python {sys.argv[0]}")
317+
print(f" FLASHINFER_LOGLEVEL={level} python {sys.argv[0]}")
318318

319319
print("\n" + "=" * 80)
320320
print("Benchmark complete!")

flashinfer/api_logging.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ def _substitute_process_id(path: str) -> str:
3939

4040

4141
# Read environment variables once at module load time
42-
_API_LOG_LEVEL = int(os.environ.get("FLASHINFER_APILEVEL", "0"))
43-
_API_LOG_DEST = _substitute_process_id(os.environ.get("FLASHINFER_APIDEST", "stdout"))
42+
_API_LOG_LEVEL = int(os.environ.get("FLASHINFER_LOGLEVEL", "0"))
43+
_API_LOG_DEST = _substitute_process_id(os.environ.get("FLASHINFER_LOGDEST", "stdout"))
4444

4545
# Create logger using Python's logging library
4646
_logger = logging.getLogger("flashinfer.api")
@@ -54,7 +54,7 @@ def _setup_logger():
5454
_logger.setLevel(logging.CRITICAL + 1) # Higher than any level
5555
return
5656

57-
# All enabled levels use loggging.DEBUG; verbosity is controlled by FLASHINFER_APILEVEL instead
57+
# All enabled levels use loggging.DEBUG; verbosity is controlled by FLASHINFER_LOGLEVEL instead
5858
_logger.setLevel(logging.DEBUG)
5959

6060
# Remove any existing handlers
@@ -466,17 +466,17 @@ def flashinfer_api(func: Callable = None) -> Callable:
466466
Decorator to log FlashInfer API calls using Python's logging library.
467467
468468
This decorator integrates with Python's standard logging infrastructure while
469-
maintaining zero overhead when disabled (FLASHINFER_APILEVEL=0).
469+
maintaining zero overhead when disabled (FLASHINFER_LOGLEVEL=0).
470470
471471
Environment Variables
472472
---------------------
473-
FLASHINFER_APILEVEL : int (default: 0)
473+
FLASHINFER_LOGLEVEL : int (default: 0)
474474
- 0: No logging (zero overhead - decorator returns original function)
475475
- 1: Log function name only (logged BEFORE execution - crash-safe)
476476
- 3: Log function name + inputs/outputs with metadata (inputs logged BEFORE execution - crash-safe)
477477
- 5: Log function name + inputs/outputs with metadata + tensor statistics (inputs logged BEFORE execution - crash-safe)
478478
479-
FLASHINFER_APIDEST : str (default: "stdout")
479+
FLASHINFER_LOGDEST : str (default: "stdout")
480480
- "stdout": Log to standard output
481481
- "stderr": Log to standard error
482482
- <path>: Log to specified file path
@@ -494,7 +494,7 @@ def flashinfer_api(func: Callable = None) -> Callable:
494494
-----
495495
- Key header lines include a timestamp in the format: [YYYY-MM-DD HH:MM:SS]
496496
(e.g., "FlashInfer API Call: function_name", "FlashInfer API Logging - System Information")
497-
- When FLASHINFER_APILEVEL=0, the decorator has truly zero overhead
497+
- When FLASHINFER_LOGLEVEL=0, the decorator has truly zero overhead
498498
as it returns the original function unchanged.
499499
- Function names and inputs are logged BEFORE execution:
500500
- Level 1: Function name only

tests/utils/test_logging.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,30 +47,30 @@ class TestAPILogging:
4747
def setup_and_teardown(self):
4848
"""Reset environment and reimport logging module for each test."""
4949
# Store original environment
50-
original_level = os.environ.get("FLASHINFER_APILEVEL")
51-
original_dest = os.environ.get("FLASHINFER_APIDEST")
50+
original_level = os.environ.get("FLASHINFER_LOGLEVEL")
51+
original_dest = os.environ.get("FLASHINFER_LOGDEST")
5252

5353
yield
5454

5555
# Restore original environment
5656
if original_level is not None:
57-
os.environ["FLASHINFER_APILEVEL"] = original_level
58-
elif "FLASHINFER_APILEVEL" in os.environ:
59-
del os.environ["FLASHINFER_APILEVEL"]
57+
os.environ["FLASHINFER_LOGLEVEL"] = original_level
58+
elif "FLASHINFER_LOGLEVEL" in os.environ:
59+
del os.environ["FLASHINFER_LOGLEVEL"]
6060

6161
if original_dest is not None:
62-
os.environ["FLASHINFER_APIDEST"] = original_dest
63-
elif "FLASHINFER_APIDEST" in os.environ:
64-
del os.environ["FLASHINFER_APIDEST"]
62+
os.environ["FLASHINFER_LOGDEST"] = original_dest
63+
elif "FLASHINFER_LOGDEST" in os.environ:
64+
del os.environ["FLASHINFER_LOGDEST"]
6565

6666
# Force reimport to pick up new environment variables
6767
if "flashinfer.api_logging" in sys.modules:
6868
del sys.modules["flashinfer.api_logging"]
6969

7070
def setup_logging(self, level: int, dest: str = "stdout"):
7171
"""Helper to set up logging environment and reimport."""
72-
os.environ["FLASHINFER_APILEVEL"] = str(level)
73-
os.environ["FLASHINFER_APIDEST"] = dest
72+
os.environ["FLASHINFER_LOGLEVEL"] = str(level)
73+
os.environ["FLASHINFER_LOGDEST"] = dest
7474

7575
# Force reimport
7676
if "flashinfer.api_logging" in sys.modules:

0 commit comments

Comments
 (0)