Skip to content

Conversation

@noot
Copy link
Contributor

@noot noot commented Nov 4, 2025

πŸ“ Summary

removal of logic in #310

πŸ’‘ Motivation and Context

we don't want non-active builders to publish flashblocks to ws, as it requires additional rollup-boost changes.

βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Copilot AI review requested due to automatic review settings November 4, 2025 18:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes WebSocket publishing functionality from the synced flashblocks code path. The change eliminates the ws_pub parameter and its associated publishing logic when handling synced flashblocks, while keeping the execution and payload event handling intact.

Key Changes:

  • Removed WebSocketPublisher dependency and parameter passing through the payload handler
  • Eliminated WebSocket publishing code block and related metrics recording for synced flashblocks
  • Cleaned up unused metrics() accessor method

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/op-rbuilder/src/builders/flashblocks/service.rs Removed ws_pub parameter from PayloadHandler initialization
crates/op-rbuilder/src/builders/flashblocks/payload_handler.rs Removed WebSocketPublisher import, struct field, constructor parameter, and publishing logic from payload execution handler
crates/op-rbuilder/src/builders/flashblocks/ctx.rs Removed unused metrics() accessor method

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@noot noot merged commit b473f4e into main Nov 4, 2025
4 checks passed
@noot noot deleted the noot/remove-ws-pub branch November 4, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants