Add minTimestamp and maxTimestamp as optional fields to bundle

Author: akundaz

crates/op-rbuilder/src/primitives/bundle.rs

@@ -28,6 +28,22 @@ pub struct Bundle {
         skip_serializing_if = "Option::is_none"
     )]
     pub block_number_min: Option<u64>,
+
+    // Not recommended because this is subject to the builder node clock
+    #[serde(
+        default,
+        rename = "minTimestamp",
+        skip_serializing_if = "Option::is_none"
+    )]
+    pub min_timestamp: Option<u64>,
+
+    // Not recommended because this is subject to the builder node clock
+    #[serde(
+        default,
+        rename = "maxTimestamp",
+        skip_serializing_if = "Option::is_none"
+    )]
+    pub max_timestamp: Option<u64>,
 }
 
 impl From<BundleConditionalError> for EthApiError {
@@ -110,8 +126,8 @@ impl Bundle {
             block_number_min,
             block_number_max,
             known_accounts: Default::default(),
-            timestamp_max: None,
-            timestamp_min: None,
+            timestamp_max: self.max_timestamp,
+            timestamp_min: self.min_timestamp,
         })
     }
 }
@@ -133,6 +149,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: None,
             block_number_min: None,
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;
@@ -152,6 +170,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: Some(1005),
             block_number_min: Some(1002),
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;
@@ -168,6 +188,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: Some(1005),
             block_number_min: Some(1010),
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;
@@ -189,6 +211,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: Some(999),
             block_number_min: None,
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;
@@ -210,6 +234,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: Some(1020),
             block_number_min: None,
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;
@@ -232,6 +258,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: None,
             block_number_min: Some(1015),
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;
@@ -253,6 +281,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: None,
             block_number_min: Some(1005),
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;
@@ -269,6 +299,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: Some(1008),
             block_number_min: None,
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;
@@ -285,6 +317,8 @@ mod tests {
             reverting_hashes: None,
             block_number_max: None,
             block_number_min: Some(999),
+            min_timestamp: None,
+            max_timestamp: None,
         };
 
         let last_block = 1000;

crates/op-rbuilder/src/tests/framework/txs.rs

@@ -27,6 +27,8 @@ use super::FUNDED_PRIVATE_KEYS;
 pub struct BundleOpts {
     pub block_number_max: Option<u64>,
     pub block_number_min: Option<u64>,
+    pub min_timestamp: Option<u64>,
+    pub max_timestamp: Option<u64>,
 }
 
 #[derive(Clone)]
@@ -194,6 +196,8 @@ impl TransactionBuilder {
                 },
                 block_number_max: bundle_opts.block_number_max,
                 block_number_min: bundle_opts.block_number_min,
+                min_timestamp: bundle_opts.min_timestamp,
+                max_timestamp: bundle_opts.max_timestamp,
             };
 
             let result: BundleResult = provider

crates/op-rbuilder/src/tests/vanilla/revert.rs

@@ -188,6 +188,8 @@ async fn bundle_min_block_number() -> eyre::Result<()> {
         .with_bundle(BundleOpts {
             block_number_max: None,
             block_number_min: Some(2),
+            min_timestamp: None,
+            max_timestamp: None,
         })
         .send()
         .await?;
@@ -206,6 +208,8 @@ async fn bundle_min_block_number() -> eyre::Result<()> {
         .with_bundle(BundleOpts {
             block_number_max: Some(4),
             block_number_min: Some(4),
+            min_timestamp: None,
+            max_timestamp: None,
         })
         .send()
         .await?;
@@ -242,6 +246,8 @@ async fn bundle_range_limits() -> eyre::Result<()> {
             .with_bundle(BundleOpts {
                 block_number_max,
                 block_number_min,
+                min_timestamp: None,
+                max_timestamp: None,
             })
             .send()
             .await