Flashtestations flag (#165)

* Add feature flag for flashtestations

* fix fmt command

Author: avalonche

Makefile

@@ -54,10 +54,11 @@ test: ## Run the tests for rbuilder and op-rbuilder
 .PHONY: lt
 lt: lint test ## Run "lint" and "test"
 
+## TODO: use all features when tdx dependency is compatible with macOS
 .PHONY: fmt
 fmt: ## Format the code
 	cargo +nightly fmt
-	cargo +nightly clippy --all-features --fix --allow-staged --allow-dirty
+	cargo +nightly clippy --features ci-features --fix --allow-staged --allow-dirty
 	cargo +nightly fix --allow-staged --allow-dirty
 
 .PHONY: bench

README.md

@@ -47,7 +47,7 @@ cargo run -p op-rbuilder --bin op-rbuilder -- node \
 To run op-rbuilder with flashtestations:
 
 ```bash
-cargo run -p op-rbuilder --bin op-rbuilder -- node \
+cargo run -p op-rbuilder --bin op-rbuilder --features=flashtestations -- node \
     --chain /path/to/chain-config.json \
     --http \
     --authrpc.port 9551 \

crates/op-rbuilder/Cargo.toml

@@ -121,8 +121,8 @@ hex = "0.4"
 ureq = "2.10"
 
 rollup-boost = { git = "https://github.com/flashbots/rollup-boost", branch = "main" }
-tdx = { git = "https://github.com/automata-network/tdx-attestation-sdk.git"}
-dcap-rs = { git = "https://github.com/automata-network/dcap-rs.git" }
+tdx = { git = "https://github.com/automata-network/tdx-attestation-sdk.git", optional = true }
+dcap-rs = { git = "https://github.com/automata-network/dcap-rs.git", optional = true }
 
 dashmap = { version = "6.1", optional = true }
 nanoid = { version = "0.4", optional = true }
@@ -175,7 +175,6 @@ min-info-logs = ["tracing/release_max_level_info"]
 min-debug-logs = ["tracing/release_max_level_debug"]
 min-trace-logs = ["tracing/release_max_level_trace"]
 
-
 testing = [
 	"dashmap",
 	"nanoid",
@@ -187,13 +186,28 @@ testing = [
 	"rlimit",
 ]
 
-
 interop = []
 
+flashtestations = ["dcap-rs", "tdx"]
+
 telemetry = ["reth-tracing-otlp", "opentelemetry"]
 
 custom-engine-api = []
 
+ci-features = [
+    "default",
+    "jemalloc-prof",
+    "min-error-logs",
+    "min-warn-logs",
+    "min-info-logs",
+    "min-debug-logs",
+    "min-trace-logs",
+	"testing",
+	"interop",
+	"telemetry",
+	"custom-engine-api",
+]
+
 [[bin]]
 name = "op-rbuilder"
 path = "src/bin/op-rbuilder/main.rs"

crates/op-rbuilder/src/flashtestations/attestation.rs

@@ -1,4 +1,5 @@
 use std::io::Read;
+#[cfg(feature = "flashtestations")]
 use tdx::{device::DeviceOptions, Tdx};
 use tracing::info;
 use ureq;
@@ -20,22 +21,26 @@ pub trait AttestationProvider {
 }
 
 /// Real TDX hardware attestation provider
+#[cfg(feature = "flashtestations")]
 pub struct TdxAttestationProvider {
     tdx: Tdx,
 }
 
+#[cfg(feature = "flashtestations")]
 impl Default for TdxAttestationProvider {
     fn default() -> Self {
         Self::new()
     }
 }
 
+#[cfg(feature = "flashtestations")]
 impl TdxAttestationProvider {
     pub fn new() -> Self {
         Self { tdx: Tdx::new() }
     }
 }
 
+#[cfg(feature = "flashtestations")]
 impl AttestationProvider for TdxAttestationProvider {
     fn get_attestation(&self, report_data: [u8; 64]) -> eyre::Result<Vec<u8>> {
         self.tdx
@@ -85,6 +90,16 @@ pub fn get_attestation_provider(
                 .unwrap_or(DEBUG_QUOTE_SERVICE_URL.to_string()),
         ))
     } else {
-        Box::new(TdxAttestationProvider::new())
+        #[cfg(feature = "flashtestations")]
+        {
+            Box::new(TdxAttestationProvider::new())
+        }
+        #[cfg(not(feature = "flashtestations"))]
+        {
+            info!("Using debug attestation provider as flashtestations feature is disabled");
+            Box::new(DebugAttestationProvider::new(
+                DEBUG_QUOTE_SERVICE_URL.to_string(),
+            ))
+        }
     }
 }