Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add reverts to eth_estimateBundleGas #111

Open
bertmiller opened this issue Jan 16, 2022 · 1 comment
Open

[Feature request] Add reverts to eth_estimateBundleGas #111

bertmiller opened this issue Jan 16, 2022 · 1 comment

Comments

@bertmiller
Copy link
Member

A request from a searcher:

Rationale

This is the current output when eth_callBundle is called on a reverting bundle

{'bundleGasPrice': '0',
 'bundleHash': '0x7abc07a2de269530f4f77cbde9c1979297d4577e673fe09b52fcb1c8bbfb8e54',
 'coinbaseDiff': '0',
 'ethSentToCoinbase': '0',
 'gasFees': '0',
 'results': [{'coinbaseDiff': '0',
   'error': 'execution reverted',
   'ethSentToCoinbase': '0',
   'fromAddress': '0xabcd',
   'gasFees': '0',
   'gasPrice': '0',
   'gasUsed': 24211,
   'toAddress': '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2',
   'txHash': '0x5bc1382d2c8165def27854e0a61c1e6dc4e85a1e1da2b81d2d429a10b593d227'}],
 'stateBlockNumber': 14017260,
 'totalGasUsed': 24211}

This is the results of calling eth_estimateBundleGas when calling on a reverting bundle:
{'results': [{'gasUsed': 24223}]}

It would be good to return a similar "error" vs no error on estimateGasBundle

Implementation

Implementation should be relatively straight forward, it would be possible to reuse some of the work with eth_callBundle.

@ziadghali2
Copy link

ziadghali2 commented Dec 14, 2022

revert estimated gas err #144
@bertmiller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants