Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time domain #4

Open
joamatab opened this issue Feb 18, 2022 · 16 comments
Open

time domain #4

joamatab opened this issue Feb 18, 2022 · 16 comments

Comments

@joamatab
Copy link
Contributor

How could we add time domain simulations to SAX?

similar to photontorch

@flaport
Copy link
Owner

flaport commented Feb 19, 2022

I could probably implement something similar to photontorch, but personally i'd like a better implementation.

That said. I think it could be a good starting point. I'll give it a go one of the coming days/weeks when I find the time.

@joamatab
Copy link
Contributor Author

@joamatab
Copy link
Contributor Author

in particular this repo has a time domain for electronics

https://github.com/TeledyneLeCroy/SignalIntegrity

@ChrisDaunt1984
Copy link

Hi, Is there any progress on this?
SignalIntegrity is being used, in combination with a in-house photonic models to perform end to end electronic-photonic simulations. Unfortunately, SignalIntegrity supports just linear models for now so "memory" effects like what is possible with Caphe and PhotonTorch are not possible. I would like to move our in-house models to something more scalable like photontorch (which is not that active?) or SAX if it supported time domain so am interested in hearing if there is any progress.

@flaport
Copy link
Owner

flaport commented Aug 31, 2022

Hi @ChrisDaunt1984 ,

Photontorch is basically in maintenance mode, I kind of like the SAX approach better (sparse by default, swappable backends, ...). It also integrates better with GDSFactory.

To be honest, I currently don't have the time to work on this, but I have some ideas on how to best implement a simple version (just like the photontorch one). I of course don't know your schedule but if you'd like to implement something like this for SAX, I can give you some guidance and I'd happily give you ownership over it 😉

Let me know if you're interested.

@ChrisDaunt1984
Copy link

Hi @flaport

OK, if photontorch is in limbo, then probably best not to invest time into it. I looked at the implementation and I think I can follow what's going on (just).

Currently, our scipy/numpy solution works and integrates with SignalIntegrity. Pete will actually demo it at ECOC so I'm am not under immediate pressure, but I am kind of unsatisfied with the scalability so looking at other options.

Id like to say that I have the time and am interested but realistically, I won't have the time either until after November. Saying that, I am interested in working on this (or contributing where I can)

@flaport
Copy link
Owner

flaport commented Sep 3, 2022

sounds good! I'll ping you in November 🙂

@joamatab
Copy link
Contributor Author

joamatab commented Sep 4, 2022

Maybe we can port the time domain model from simphony into SAX.

@SkandanC
@sequoiap
@cjcarver
@AustP
@alexsludds

@jan-david-fischbach
Copy link
Contributor

Hey @ChrisDaunt1984, @flaport, @joamatab,
is there currently work in progress on this, or is it still untouched? Do you see fit for me to help somehow?
Regards
JD

@ChrisDaunt1984
Copy link

Hey @Jan-David-Black
I have not been able to touch it and will probably now not be able to get around to it in the short term (schedules have changed).
I am still interested in the availability though

@joamatab
Copy link
Contributor Author

Now that we have schematic driven layout it would be great to interface with signalIntegrity, which is time domain capable
https://github.com/TeledyneLeCroy/SignalIntegrity

@flaport
Copy link
Owner

flaport commented Nov 30, 2022

Hey @ChrisDaunt1984, @flaport, @joamatab, is there currently work in progress on this, or is it still untouched? Do you see fit for me to help somehow? Regards JD

Hi @Jan-David-Black ,

This issue has not been touched. Feel free to pick it up!

@joamatab
Copy link
Contributor Author

Time domain models for memory container blocks

JAX may have a better way to do this

@SkandanC
Copy link

Hello @joamatab,

There is a project in the CamachoLab where they are trying to write Simphony in JAX, and add time domain stuff

@ChrisDaunt1984
Copy link

Hi

Reading up on JAX related things a bit more and seeing what is available. Most of these "memory" artifacts are usually handled by tracking some form of internal state vs time (charge, temperature, energy... etc). In the case of Caphe and PhotonTorch (I believe) or Verilog-A for electronics, this is handled by numerically integrating an ODE for each time step.

JAX seems to already have at least an experimental ode solver in place which looks like it could be used https://github.com/google/jax/blob/main/jax/experimental/ode.py

Alternatively, I like the look of https://github.com/patrick-kidger/diffrax where one can step through the integration allowing the input and output optical/electronic signals at the circuit nodes to be updated at each time step
https://docs.kidger.site/diffrax/usage/manual-stepping/

@flaport
Copy link
Owner

flaport commented Jan 23, 2023

Indeed, tracking an internal state and integrating over it is the default way of tackling such time dependent problems.

Diffrax seems to be almost exactly what we need for this. Good find! I'll have to play around a bit with it to get to know it a bit better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants