Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module is not redeployed if only helm hook changed in the template #408

Open
nabokihms opened this issue Sep 11, 2023 · 0 comments
Open

Comments

@nabokihms
Copy link
Contributor

Addon-operator compares checksums of the current and previous helm templates. However, helm hooks are not included in manifests.

// ShouldRunHelmUpgrade tells if there is a case to run `helm upgrade`:
// - Helm chart in not installed yet.
// - Last release has FAILED status.
// - Checksum in release values not equals to checksum argument.
// - Some resources installed previously are missing.
//
// If all these conditions aren't met, helm upgrade can be skipped.
func (m *Module) ShouldRunHelmUpgrade(helmClient client.HelmClient, releaseName string, checksum string, manifests []manifest.Manifest, logLabels map[string]string) (bool, error) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant