Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one component exception will affect the deployment process of multiple components #228

Open
xiqiu618 opened this issue Jul 25, 2021 · 1 comment

Comments

@xiqiu618
Copy link

Expected behavior (what you expected to happen):
The management of multiple components is decoupled from each other and has complementary effectsActual behavior (what actually happened):
one component exception will affect the deployment process of multiple components

Environment:

  • Addon-operator version: v1.0.0-rc.1
  • Helm version: v3
  • Kubernetes version: 1.16.9
  • Installation type (kubectl apply, helm chart, etc.): helm chart

Anything else we should know?:

for _, moduleName := range enabledModules {
if err = mm.RegisterModuleHooks(mm.allModulesByName[moduleName], logLabels); err != nil {
return nil, err
}
}

Additional information for debugging (if necessary):

Hook script

Logs

@diafour
Copy link
Contributor

diafour commented Mar 11, 2022

Hello! Sorry for the long delay.
You quote a code related to configuring hooks at module start. It’s easy to catch these errors with simple tests before releasing.
We consider that the act of bundling hooks and modules in one image is a release of the solution. If there is an error in configuring just one hook at start, the solution might not work at all, so it is crucial to stop and wait until the fixed image arrives.

Can you get more details on your components and describe the reason to tolerate configuring errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants