Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletaion for active tool does not work #3228

Open
KES777 opened this issue Jun 12, 2023 · 9 comments
Open

Deletaion for active tool does not work #3228

KES777 opened this issue Jun 12, 2023 · 9 comments
Labels
Enhancement Feature requests and code enhancements Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed.

Comments

@KES777
Copy link

KES777 commented Jun 12, 2023

Flameshot Version

Flameshot v11.0.0 (11.0.0-2 Debian)
Compiled with Qt 5.15.2

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

Linux Mint v21.1 Cinnamon

Description

I tried to

image

Steps to reproduce

  1. run flameshot gui
  2. Select tool c
  3. Try to delete current tool Del

If you press Esc it deselects current tool though.

Screenshots or screen recordings

dd

System Information

Linux Mint v21.1 Cinnamon

System:
Host: kes-X406UA Kernel: 5.15.0-73-generic x86_64 bits: 64
Desktop: Cinnamon 5.6.8 Distro: Linux Mint 21.1 Vera
Graphics:
Device-1: Intel HD Graphics 620 driver: i915 v: kernel
Device-2: IMC Networks USB2.0 HD UVC WebCam type: USB driver: uvcvideo
Display: x11 server: X.Org v: 1.21.1.4 driver: X: loaded: modesetting
unloaded: fbdev,vesa gpu: i915 resolution: 1920x1080~60Hz
OpenGL: renderer: Mesa Intel HD Graphics 620 (KBL GT2) v: 4.6 Mesa 22.2.5

@KES777 KES777 added the Unconfirmed Bug The bug is not confirmed by anyone else. label Jun 12, 2023
@mmahmoudian
Copy link
Member

mmahmoudian commented Jun 12, 2023

I think we have used a bad word here. By "delete current tool" what we mean is "delete the selected object". This is used in the following scenario:

  1. open flameshot gui
  2. select a tool (e.g arrow by pressing a)
  3. draw something
  4. deselect the tool (e.g by clicking on the tool again, or pressing Esc or pressing a)
  5. select what you have draw (a dotted rectangle appears around the object)
  6. press Del

I change this to Enhancement rather than a bug. Also please feel free to suggest alternative text.

@mmahmoudian mmahmoudian added Enhancement Feature requests and code enhancements Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed. and removed Unconfirmed Bug The bug is not confirmed by anyone else. labels Jun 12, 2023
@mmahmoudian mmahmoudian self-assigned this Jun 12, 2023
@KES777
Copy link
Author

KES777 commented Jun 12, 2023

@mmahmoudian oh... I used Flameshot couple of years, but never know that I can delete what I draw not by CTRL+z undo it! Why help message was not displayed for tools too??

Ok. Thank you for this tip! It seems would be useful to have "hand" tool. So people could see it and understand that it is possible to select something when none other tools were selected. eg. when deselecting current tool - activate "hand" tool by default.

  1. Implement "hand" tool

  2. For backward compatibility "Show 'hand' tool" option could be implemented (enabled by default). So old users could disable it.

  3. My proposition for name is: Delete selected drawn object

@KES777

This comment was marked as off-topic.

@mmahmoudian

This comment was marked as off-topic.

@KES777

This comment was marked as off-topic.

@mmahmoudian

This comment was marked as off-topic.

@mmahmoudian

This comment was marked as off-topic.

@mmahmoudian
Copy link
Member

mmahmoudian commented Jun 13, 2023

I just realized the name change should be done before closing the issue. I checked and it can be straightforward thing but the translations would make it complicated for me to change. I would rather wait for other devs to do it or suggest the best way so I can do it myself.

This is what should be done:
Delete current tool -> Delete selected drawn object

@mmahmoudian mmahmoudian removed their assignment Jun 13, 2023
@Amangupta0000
Copy link

#3348 (comment)
Changed the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and code enhancements Good first issue Issues labeled as such are a good way to get use to the codebase. Ask for help if needed.
Projects
None yet
Development

No branches or pull requests

3 participants