-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for mobile devices #35
Comments
Hi @FlamingArr, thanks for the feedback. I am currently wrapping up a release but will look into this for the next release. |
I was able to get around to investigating some issues with mobile support. The one that stands out is the Android status bar that is rendered on top of Love. Love currently has a function called 'love.window.getSafeArea', but unfortunately does not seem to return the correct results. This may be fixed in a future version as discussed in this thread here. There are some other minor issues that I have found that will be addressed in future releases. I wanted to reach out and see if you have noticed any other issues with running Slab on mobile devices. |
Hi, I just tried out the current master branch and this error is thrown when running the bundled program and switching to 'Window' from 'Overview'
The last coordinate mess up issue seems to be perfectly fixed, thanks. |
This crash is fixed for the upcoming patch release and has been addressed in issue #58. We can revisit this issue after the release. |
There is another minor issue where after clicking on a button, the button belives it is being hovered on until one clicks somewhere else. |
Thanks for the info. I'll look into this for the patch release. |
Re: Input Slab should enable the keyboard when the edittext field is clicked on and should disable it when somewhere else is clicked. |
Hi @FlamingArr , I was about to fix this but it seems that it was already fixed. Please test again using the v0.8.0 and let me know if this issue is solved already. |
Yeah this issue seems to be solved now though the |
In the meantime, docks are not working either, they worked before. I can programatically dock/undock windows but doing it through the UI doesn't work |
Thanks for the updates @FlamingArr , will test it as soon as possible. For the For the docks, i think it has something to do with touch events in Android acting differently. This is tricky to test since compiling a love project for android takes longer time |
Thinking about it, I think |
This behavior doesn't happen on desktop right? 🤔 If so, then i think it's due to the input losing focus when the window is touched and that clears it as well. That is indeed not a sane behavior |
@flamendless, Some notes:
Thanks! |
@SugarRayLua thanks! For #2, what are those calls you modify? |
Thanks, @flamendless, I included an iOS screenshot of the initial error I get when trying to run Slab and then a second screenshot of a partial list of all references to that call in "Mouse.lua" in the Input folder of slap. |
@SugarRayLua are you using the latest commit? I pushed a similar fix in #151 |
@flamendless : sorry, you are correct-- the fix in the latest commit corrects the problem. I'm still rather a novice at github and wasn't understanding exactly how to determine whether a commit fixed a problem after the last release and then download the master with that commit in it. I now understand that better, thank you. |
@SugarRayLua we learn each day! Thank you |
This ui library looks very good! It would be awesome if you consider providing a mobile device backend to it, It seems to mess up the coordinates when I try to use it on my Android
The text was updated successfully, but these errors were encountered: