Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong "Channel Count" in DrawCommand stats #113

Open
megagrump opened this issue Dec 21, 2021 · 5 comments
Open

Wrong "Channel Count" in DrawCommand stats #113

megagrump opened this issue Dec 21, 2021 · 5 comments
Labels
bug Something isn't working v1.0.0

Comments

@megagrump
Copy link
Contributor

Looking at issue #112, the "Channel Count" statistics is not accurate. It shows a value of "0" for every layer even though there are obviously more than 0 channels in some layers (otherwise no UI would be visible on screen).

The GetLayerDebugInfo function in Internal/Core/DrawCommands.lua is faulty. It uses the length of the Layer table for statistics, which is always 0 - it's a hash table that has no length.

As I'm trying to optimize the DrawCommands module for performance, I wonder if Channel Count is an important metric at all? I don't even understand what "Channel" even means in this context.

@flamendless
Copy link
Owner

Hmm right 🤔 i dont even know what channel is for in this context. I think it's just for demoing tree nodes but then again if i remember correctly there are other demos for nested tree nodes.

I'll take a closer look later and see if i can figure out its purpose. If not found, I'll remove it.

@megagrump
Copy link
Contributor Author

Please leave it alone for the time being, until I'm done working on the DrawCommands module. It may fall all into place if I understand it better, and it may just need a better name.

@flamendless
Copy link
Owner

@megagrump i got an email notif about the styling issue but i dont see it anywhere. Did you delete it?

@flamendless
Copy link
Owner

Still cant. I get "no commit found for the ref 111"

@megagrump megagrump reopened this Dec 22, 2021
@flamendless
Copy link
Owner

flamendless commented Dec 22, 2021

@megagrump yeah i click it and it doesn't redirect anywhere

I also dont see it in your forked repo 🤔

@flamendless flamendless added bug Something isn't working v1.0.0 labels Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0
Projects
None yet
Development

No branches or pull requests

2 participants