cambricon: update cambricon code based on master #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chenmiao1919
force-pushed
the
cambricon_merge_to_master_q4
branch
3 times, most recently
from
dee097c to
8c21ce7
Compare
kiddyjinjin
reviewed
Dec 1, 2025
| shift_amount = torch.randint( | ||
| 0, 8, shape, dtype=cur_dtype, device=self.device | ||
| shift_amount = torch.randint(0, 8, shape, dtype=cur_dtype, device="cpu").to( | ||
| self.device |
Collaborator
There was a problem hiding this comment.
Is there any difference between these two expressions？
Contributor
Author
There was a problem hiding this comment.
Since the randint function in our torch-mlu does not support specific data types (e.g., i16), we’ve made this temporary modification for now. Support for these types will be added in future.
kiddyjinjin
reviewed
Dec 1, 2025
chenmiao1919
force-pushed
the
cambricon_merge_to_master_q4
branch
2 times, most recently
from
53e6f62 to
20ca84b
Compare
Collaborator
|
lgtm |
kiddyjinjin
previously approved these changes
Dec 2, 2025
chenmiao1919
force-pushed
the
cambricon_merge_to_master_q4
branch
from
20ca84b to
8380751
Compare
chenmiao1919
force-pushed
the
cambricon_merge_to_master_q4
branch
9 times, most recently
from
fdce5f1 to
63166a3
Compare
chenmiao1919
force-pushed
the
cambricon_merge_to_master_q4
branch
from
63166a3 to
bffbc93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
Performance Optimization
Description
update cambricon to master
Issue
Progress
Performance