From 036cae36697a6c078fe28ac6088a2a493d0e7958 Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Fri, 13 May 2022 10:04:10 -0700 Subject: [PATCH] Enforce minimum plugin version iOS 11 (#103545) --- dev/devicelab/lib/tasks/plugin_tests.dart | 6 +++--- packages/flutter_tools/bin/podhelper.rb | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dev/devicelab/lib/tasks/plugin_tests.dart b/dev/devicelab/lib/tasks/plugin_tests.dart index f04de8469829..240f1577fe6b 100644 --- a/dev/devicelab/lib/tasks/plugin_tests.dart +++ b/dev/devicelab/lib/tasks/plugin_tests.dart @@ -204,7 +204,7 @@ class $dartPluginClass { podspecContent = podspecContent.replaceFirst( versionString, target == 'ios' - ? "s.platform = :ios, '7.0'" + ? "s.platform = :ios, '10.0'" : "s.platform = :osx, '10.8'" ); podspec.writeAsStringSync(podspecContent, flush: true); @@ -240,8 +240,8 @@ class $dartPluginClass { if (target == 'ios') { // Plugins with versions lower than the app version should not have IPHONEOS_DEPLOYMENT_TARGET set. // The plugintest plugin target should not have IPHONEOS_DEPLOYMENT_TARGET set since it has been lowered - // in _reduceDarwinPluginMinimumVersion to 7, which is below the target version of 9. - if (podsProjectContent.contains('IPHONEOS_DEPLOYMENT_TARGET = 7')) { + // in _reduceDarwinPluginMinimumVersion to 10, which is below the target version of 11. + if (podsProjectContent.contains('IPHONEOS_DEPLOYMENT_TARGET = 10')) { throw TaskResult.failure('Plugin build setting IPHONEOS_DEPLOYMENT_TARGET not removed'); } if (!podsProjectContent.contains(r'"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "$(inherited) i386";')) { diff --git a/packages/flutter_tools/bin/podhelper.rb b/packages/flutter_tools/bin/podhelper.rb index 49a3c5bbcae6..639e32b8bdf2 100644 --- a/packages/flutter_tools/bin/podhelper.rb +++ b/packages/flutter_tools/bin/podhelper.rb @@ -34,7 +34,7 @@ def flutter_additional_ios_build_settings(target) return unless target.platform_name == :ios # [target.deployment_target] is a [String] formatted as "8.0". - inherit_deployment_target = target.deployment_target[/\d+/].to_i < 9 + inherit_deployment_target = target.deployment_target[/\d+/].to_i < 11 # This podhelper script is at $FLUTTER_ROOT/packages/flutter_tools/bin. # Add search paths from $FLUTTER_ROOT/bin/cache/artifacts/engine.