Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Go 1.23 #5

Open
yorickdowne opened this issue Aug 14, 2024 · 8 comments
Open

Add compatibility with Go 1.23 #5

yorickdowne opened this issue Aug 14, 2024 · 8 comments

Comments

@yorickdowne
Copy link

Projects that include memsize tend to fail with link: github.com/fjl/memsize: invalid reference to runtime.stopTheWorld

Compilation with Go 1.22 works

@fjl
Copy link
Owner

fjl commented Aug 14, 2024

I tried... golang/go#68167

@fjl
Copy link
Owner

fjl commented Aug 14, 2024

Projects which are forks of go-ethereum can apply this patch to remove memsize: ethereum/go-ethereum@e467577

@yorickdowne
Copy link
Author

Thank you!

@fjl fjl reopened this Aug 14, 2024
@fjl
Copy link
Owner

fjl commented Aug 14, 2024

I will leave this open for now. Perhaps a solution can be found.

@fjl
Copy link
Owner

fjl commented Aug 14, 2024

I'm considering to publish a new version that just panics on Go 1.23. That would be for downstream consumers who depend on memsize via another project, but are affected by the issue.

@ARitz-Cracker
Copy link

I'm considering to publish a new version that just panics on Go 1.23. That would be for downstream consumers who depend on memsize via another project, but are affected by the issue.

Would appreciate it. I had to build something that uses your library as a transient dependency for a demo, and I did the naive thing of installing the latest version of the Go compiler. A message telling me that you're only compatible with < 1.23 (and perhaps linking this issue) would have saved me some panicked searching.

@fjl
Copy link
Owner

fjl commented Aug 26, 2024

I don't really know where to put the message though. In the repo description?

@ARitz-Cracker
Copy link

ARitz-Cracker commented Aug 26, 2024

I don't really know where to put the message though. In the repo description?

What you've got in #6 seems fine, just add "for more information, see github.com/fjl/ memsize/ issues/ 5" (spaces where added due to GitHub's auto formatting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants