Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add more context for fivetran_id in ymls #43

Open
2 of 4 tasks
fivetran-reneeli opened this issue Jul 7, 2023 · 0 comments
Open
2 of 4 tasks

[Feature] Add more context for fivetran_id in ymls #43

fivetran-reneeli opened this issue Jul 7, 2023 · 0 comments

Comments

@fivetran-reneeli
Copy link

fivetran-reneeli commented Jul 7, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

We added more fields to the unique test for the apple_search_ads__search_term_report end model so now it is the following (Pr #18):

        - search_term_text
        - match_type
        - date_day
        - keyword_id
        - ad_group_id
        - campaign_id
        - organization_id

But in the respective staging model it is:

        - _fivetran_id
        - date_day

Once we figure out how _fivetran_id gets generated (which fields do the engineers use to hash) and if it's the same fields as the aforementioned then we should add more to the definition in the yml. If not, we should consider swapping it out to use those fields.

Describe alternatives you've considered

na

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

na

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant