fix: don't pause downloads until ready #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesha-antonov/react-native-background-downloader#23 is a bug where pause() isn't respected by that library if you call it right after starting a download(). So instead, we pause only upon begin() or progress(). This isn't ideal, because you could start download some bytes, even if !startActive, between when you start/revive a task and when you're next able to pause it... but this is an external bug we can't control.
|
🎉 This PR is included in version 5.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kesha-antonov/react-native-background-downloader#23 is a bug where pause() isn't respected by that library if you call it right after starting a download(). So instead, we pause only upon begin() or progress(). This isn't ideal, because you could start download some bytes, even if !startActive, between when you start/revive a task and when you're next able to pause it... but this is an external bug we can't control.