fix: optimize setActiveNetworkTypes to not do anything when types haven't changed (#31)

Author: fivecar

src/index.ts

@@ -652,6 +652,13 @@ export default class DownloadQueue {
   async setActiveNetworkTypes(types: string[]): Promise<void> {
     this.verifyInitialized();
 
+    if (
+      this.activeNetworkTypes.length === types.length &&
+      this.activeNetworkTypes.every(type => types.includes(type))
+    ) {
+      return;
+    }
+
     this.activeNetworkTypes = types;
     if (this.netInfoFetchState) {
       const state = await this.netInfoFetchState();

test/index.spec.ts

@@ -1558,6 +1558,26 @@ describe("DownloadQueue", () => {
       await expect(queue.setActiveNetworkTypes(["wifi"])).rejects.toThrow();
     });
 
+
+    it("should do nothing when setting same active network types", async () => {
+      const queue = new DownloadQueue();
+
+      await queue.init({
+        domain: "mydomain",
+        activeNetworkTypes: ["wifi", "ethernet"],
+        netInfoAddEventListener: addEventListener,
+        netInfoFetchState: fetch,
+      });
+      expect(addEventListener).toHaveBeenCalledTimes(1);
+      expect(fetch).toHaveBeenCalledTimes(1);
+
+      await queue.setActiveNetworkTypes(["ethernet", "wifi"]);
+      expect(fetch).toHaveBeenCalledTimes(1); // no change
+
+      await queue.setActiveNetworkTypes(["ethernet", "wifi", "cellular"]);
+      expect(fetch).toHaveBeenCalledTimes(2);
+    });
+
     it("should update activeNetworkTypes to current conditions", async () => {
       const queue = new DownloadQueue();
       const state = createNetState(true);