Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recency schema test #43

Merged
merged 1 commit into from
Jan 11, 2018
Merged

added recency schema test #43

merged 1 commit into from
Jan 11, 2018

Conversation

jthandy
Copy link
Member

@jthandy jthandy commented Jan 11, 2018

this is super-cool--uses two cross-db-utils that already existed :)

@jthandy
Copy link
Member Author

jthandy commented Jan 11, 2018

@drewbanin I previously hadn't merged this because we weren't totally sure about namespacing stuff. I think we've decided in the intervening weeks that macros called within packages should be called with their own package name. that's what I did here and it worked when calling this from another package.

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible. Ship it.

@jthandy jthandy merged commit fcd3ab6 into master Jan 11, 2018
@jthandy jthandy deleted the feature/recency-test branch January 11, 2018 00:55
@drewbanin drewbanin mentioned this pull request Jan 11, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants