This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Refactor the CStr API to reduce the need for nightly features #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
refactor-cstr-to-reduce-nightly
branch
3 times, most recently
from
697fd82 to
2fcb49f
Compare
alex
force-pushed
the
refactor-cstr-to-reduce-nightly
branch
from
2fcb49f to
6979f48
Compare
|
Hrrrmm. I'm fine with this, but I think we should plan to revert it once we can, because now our API looks pretty different from I don't think Approving, I'll leave it up to you as to whether you want to merge it for now. |
geofft
approved these changes
Sep 6, 2020
|
Just to be clear, the feature in question here is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.