Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SNOTE a link on media detail page #4974

Open
HerzScheisse opened this issue Apr 1, 2024 · 7 comments
Open

make SNOTE a link on media detail page #4974

HerzScheisse opened this issue Apr 1, 2024 · 7 comments

Comments

@HerzScheisse
Copy link
Contributor

Hey,

Is it possible to make the SNOTE an the mediadetail page a link like in other parts of the website?...
While viewing the mediadetail page, the SNOTE is displayed... but it would be great if we can click on that name...

see: https://dev.webtrees.net/demo-stable/index.php?route=%2Fdemo-stable%2Ftree%2Fdemo%2Fmedia%2Fm47%2FGlamis-Castle

snote_issue_wt

I've been using the SNOTE's to track the studio who made the photo... if we could easily click on the SNOTE, we can then see the related photos to that studio... instead of coping the SNOTE name an search in the list for shared notes...

@arbor95
Copy link
Contributor

arbor95 commented Jul 23, 2024

If you know the page to link, you can.
If you have set "plain text" at the setting for Text, you simply write the url https://<what_you_want_to_link>.
If you have set "Markdown", you write the text in brackets and the link url in parentheses. [<shown_text>](<url>)

there is nothing to change within webtrees code.

So in the example screenshot, if your setting for note is plain text, the wikipedia text is clickable. (so called auto link).

@HerzScheisse
Copy link
Contributor Author

Hi,
I guess I was maybe not clear enough... and maybe you missunderstood what i was meaning...
i dont need and dont want to add links in the SNOTE input fields... i rather want the whole note in the page shown above to be clickable, to find/link to the other entries with the same SNOTE...

@arbor95
Copy link
Contributor

arbor95 commented Jul 23, 2024

but you find the usages by clicking onto the tabs (here individuals, 3 occurances).

(where do you want to click, to see what? may be you can give an image and mark your wishes)

@miqrogroove
Copy link
Contributor

miqrogroove commented Nov 30, 2024

One good workaround is to use a source for the studio or studios.

On the media oject, add a source citation, and link the SNOTE to the citation rather than directly to the media.

This will give you links both to the list of all source usage and to the specific SNOTE with its usage.

@fisharebest
Copy link
Owner

The display of 1 NOTE @x1@ is different to 2 NOTE @x1@.

Level 2 works as you expect. We have a title, and an expandable content (for multi-line notes). The title is clickable. The content can't be clickable (as it may contain links).

For level 1, we don't have the same expand/collapse, and so the text cannot be clickable.

We did once have a link icon (next to the edit/delete/copy icons) that was a link to the note. Maybe this got lost somewhere...

@fisharebest
Copy link
Owner

We could make the label itself ("Shared note") a link to the record?

@miqrogroove
Copy link
Contributor

Level 2 works as you expect. We have a title, and an expandable content (for multi-line notes). The title is clickable. The content can't be clickable (as it may contain links).

Since we're on this topic, I'm in favor of changing the level 2 output.

Could we do away with the title that always duplicates the content? I propose a new format:

  • Generic phrase "Shared note:" that is clickable. This phrase is already in use. Making it clickable is easy.
  • Below that, show "the title". Don't make the title clickable.
  • Make "the title" expandable/collapsable instead of the "Shared note" link.
  • Don't duplicate the title.

For the Level 1 display, consider using the existing edit button. There is no reason to "edit" a single SNOTE link. The user only needs to be able to delete the link and create a new link. For me, it would make sense if the edit button simply sent me to the note page. If this causes confusion because the note page has its own edit button, then consider changing the edit button to a view button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants