Please avoid node dependency to "natives" module

[bpasero]

Hi,

I am a developer on VSCode and wanted to reach out to inform you that this extension is either using or having a dependency to a node module "natives" that will soon no longer be supported in VSCode once we updated to node.js 8.x (as part of our Electron 2.0 update which is planned for the near term).

The full graph is:

└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected] 

It would be great if this dependency could be avoided by either not depending on it anymore or updating the dependencies to newer versions so that this module is no longer pulled in.

As soon as any code in your extension (including node_modules) calls require("natives") we will throw an exception to prevent this module from getting loaded.

If this is just a devDependency and the module is never loaded in production, then you can ignore this issue and just close it!

More details in microsoft/vscode#47569

Thanks!
Ben
VSCode Team

[Tyriar]

Related: EvanOxfeld/node-unzip#97

[bpasero]

A good alternative node module to unzip seems to be unzip-stream, a fork of the unzip library with similar API.

[hbenl]

Thanks for the early warning, I will replace the unzip dependency ASAP (definitely before the next VSCode release).

[bpasero]

@hbenl thanks

[hbenl]

I have replaced unzip with unzipper, which doesn't depend on natives.

There is still the gulp package which depends on natives. However, gulp is only a devDependency, so that shouldn't be a problem, right? The output of npm ls -prod doesn't contain the natives module.

[Tyriar]

@hbenl that's fine, as long as require('gulp') doesn't happen when the extension is run you're good to go 👍

[hbenl]

Thanks for clarifying.

[bpasero]

@hbenl thanks 👍