Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change seccomp_filters to be passed by value, rather than by reference. #4647

Open
jxcurtis opened this issue Jun 19, 2024 · 0 comments
Open

Change seccomp_filters to be passed by value, rather than by reference. #4647

jxcurtis opened this issue Jun 19, 2024 · 0 comments
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Parked Indicates that an issues or pull request will be revisited later

Comments

@jxcurtis
Copy link
Contributor

In PR #4638 (vCPU hotplugging) seccomp_filters are added as a field of the VMM. This was required in order to apply correct the same seccomp filters to the new vCPU threads as the existing threads. Currently, they are passed around as a reference until the create_vmm_and_vcpus, which then clones them, and the VMM takes ownership of the clone. It should be possible to slightly refactor the code to allow the VMM to take ownership of the original seccomp_filters, then when seccomp_filters is required afterwards, they can be accessed via the Vmm instance, thus keeping the same functionality and removing the need to clone.
@jxcurtis jxcurtis added Good first issue Indicates a good issue for first-time contributors Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` labels Jun 19, 2024
@jxcurtis jxcurtis mentioned this issue Jun 19, 2024
Merged
9 tasks
@zulinx86 zulinx86 added Status: Parked Indicates that an issues or pull request will be revisited later and removed Status: Parked Indicates that an issues or pull request will be revisited later Good first issue Indicates a good issue for first-time contributors labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Parked Indicates that an issues or pull request will be revisited later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zulinx86 @jxcurtis