Specify Cgroups versions for JailerConfig #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaishnavi Vejella <[email protected]>
ginglis13
approved these changes
Dec 15, 2022
kzys
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vaishnavi Vejella [email protected]
Issue #467:
TestJailerMicroVMExecution is failed to start VMM and Firecracker was not able to create an API socket due to CgroupsVersion field on the JailerConfig is not specified, thus the default is using v1 with the jailer binary.
Description of changes:
Modified the Jailer Config by specifying cgroups as v2 in TestJailerMicroVMExecution to
CgroupVersion: "2"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.