Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotprompt] Always reload .prompt files in dev mode #566

Open
mbleigh opened this issue Jul 9, 2024 · 3 comments · May be fixed by #842
Open

[dotprompt] Always reload .prompt files in dev mode #566

mbleigh opened this issue Jul 9, 2024 · 3 comments · May be fixed by #842
Assignees
Labels
feature New feature or request

Comments

@mbleigh
Copy link
Collaborator

mbleigh commented Jul 9, 2024

I suggest that when NODE_ENV=development (or GENKIT_ENV=dev) .prompt files should be automatically reloaded from disk before each invocation. This would be beneficial for a few reasons:

  1. We could stop rebooting the entire server when a .prompt file changes, speeding up iteration
  2. There would be less chance of "stale prompts" which seems to happen to me relatively frequently though I'm not sure why

To accomplish this I think we need the proxy ref construct proposed in #513, but once we had that it would be pretty trivial.

@mbleigh
Copy link
Collaborator Author

mbleigh commented Aug 4, 2024

Update on this: see #744 which is honestly even more annoying than stale prompts because it actually breaks the flow of the server. Let's solve both of these problems.

@cabljac cabljac linked a pull request Aug 30, 2024 that will close this issue
3 tasks
@cabljac
Copy link
Contributor

cabljac commented Aug 30, 2024

linking #842

@cabljac cabljac assigned CorieW and cabljac and unassigned cabljac Nov 21, 2024
@cabljac
Copy link
Contributor

cabljac commented Nov 25, 2024

#1380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants