-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_dynamic_links] plugin is not working in ios when app is in Back ground. #33
Comments
I'm going to try to check this this week. EDIT: Finally I will be able to check this next week: September 23-29 |
I've pushed a PR with the fix, can you try? You just need to point to the PR version?
|
I don't know what @dhanrajvermaRepo means with "when app is in background" because, in order to open a Dynamic link from somewhere else, your app needs to be in background for sure, so... |
@jherencia sorry, I didn't notice you were talking about default domains... I didn't try again your PR after I solved my issue like I said in in #262 |
So you were using the latest official version (0.5.0+3) not the PR when it worked, right? |
That's right |
Managed to get it working, though it's still subscribing to Also note that Navigator.pushNamed(context, deepLink.path); needs to be a child of |
I'll test my App on 8 October and let you know whether it is working or not. |
Hi, I have tested my app with this PR. It is working when app is in background. When app is in killed state it navigates to appropriate screen but returns to my root widget within a micro/millisecond. It is so fast that it seems it directly opens my root widget (root screen ie login screen). I have is used toast to debug this issue as in killed state i can not debug it. |
Can you post some example code to reproduce this? |
I am sorry. |
Great to hear, thank you! |
But one thing i forgot to mention is that in every state(Active/background, killed) onLink method's onSuccess callback is called on iOS. But in android on Active/background state onLink method's onSuccess is called and in killed state getInitial link returns deepLink. |
@jherencia I can confirm your PR fix the problem on iOS when app is in "killed state" |
why onError callback of onLink method is not called when we do not come by link in iOS? |
Because is not an error. onError is called when we clicked on a dynamic link and something fails (for example, a network call to Firebase API to resolve the short link) |
@jherencia Can I release my App with this PR? |
Well, I cannot guarantee anything about this, it's a PR which has to pass a review and a process which can end up in the repo or not. I wouldn't trust my repo because I can change things in the future without notice. It's your call to clone it and freeze the version so you can rely on your own repo or wait or whatever you think is the best for your project. |
Closing - looks like the problem is now fixed. Please create a new issue if the problem still persists as this one has generated a lot of noise from users posting stack traces without formatting. |
I have downloaded the example app from https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_dynamic_links/example.
This example is running fine on android but on ios it is doing nothing when app is in background.
In fact onLink method was never called when ios app is in background.
HELP me please.
The text was updated successfully, but these errors were encountered: