Skip to content

Commit 3c158b0

Browse files
abalalovskirussellwheatley
authored andcommitted
feat(auth): Add support for secret on OAuthCredential on web (#6830)
Co-authored-by: russellwheatley <[email protected]>
1 parent 5848dd9 commit 3c158b0

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

packages/firebase_auth/firebase_auth_platform_interface/lib/src/providers/oauth.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,15 @@ class OAuthProvider extends AuthProvider {
5050
/// Create a new [OAuthCredential] from a provided [accessToken];
5151
OAuthCredential credential({
5252
String? accessToken,
53+
String? secret,
5354
String? idToken,
5455
String? rawNonce,
5556
}) {
5657
return OAuthCredential(
5758
providerId: providerId,
5859
signInMethod: 'oauth',
5960
accessToken: accessToken,
61+
secret: secret,
6062
idToken: idToken,
6163
rawNonce: rawNonce,
6264
);

packages/firebase_auth/firebase_auth_platform_interface/test/providers_tests/oauth_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,13 @@ void main() {
5959

6060
group('credential()', () {
6161
const String kMockAccessToken = 'test-token';
62+
const String kMockSecret = 'test-secret';
6263
const String kMockIdToken = 'id';
6364
const String kMockRawNonce = 'test-raw-nonce';
6465
test('creates a new [OAuthCredential]', () {
6566
final result = oAuthProvider.credential(
6667
accessToken: kMockAccessToken,
68+
secret: kMockSecret,
6769
idToken: kMockIdToken,
6870
rawNonce: kMockRawNonce);
6971

@@ -72,6 +74,7 @@ void main() {
7274
expect(result.idToken, equals(kMockIdToken));
7375
expect(result.rawNonce, equals(kMockRawNonce));
7476
expect(result.accessToken, equals(kMockAccessToken));
77+
expect(result.secret, equals(kMockSecret));
7578
expect(result.providerId, equals(kMockProviderId));
7679
expect(result.signInMethod, equals('oauth'));
7780
});

packages/firebase_auth/firebase_auth_web/lib/src/utils/web_utils.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ AuthCredential? convertWebOAuthCredential(
212212

213213
return OAuthProvider(oAuthCredential.providerId).credential(
214214
accessToken: oAuthCredential.accessToken,
215+
secret: oAuthCredential.secret,
215216
idToken: oAuthCredential.idToken,
216217
);
217218
}

0 commit comments

Comments
 (0)