Skip to content

Commit 0f85661

Browse files
committed
fixup: Formatting and wording changes
1 parent cce6174 commit 0f85661

File tree

3 files changed

+21
-18
lines changed

3 files changed

+21
-18
lines changed

analytics/src/FirebaseAnalytics.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ public static void LogEvent(string name, IEnumerable<Parameter> parameters) {
254254
///
255255
/// @param[in] parameters A parameter array of `Parameter` instances.
256256
public static void SetDefaultEventParameters(params Parameter[] parameters){
257-
SetDefaultEventParameters((IEnumerable<Parameter>)parameters);
257+
SetDefaultEventParameters((IEnumerable<Parameter>)parameters);
258258
}
259259

260260
/// @brief Adds parameters that will be set on every event logged from the SDK.
@@ -269,15 +269,15 @@ public static void SetDefaultEventParameters(params Parameter[] parameters){
269269
///
270270
/// @param[in] parameters An enumerable list of `Parameter` instances.
271271
public static void SetDefaultEventParameters(IEnumerable<Parameter> parameters){
272-
StringList parameterNames = new StringList();
273-
VariantList parameterValues = new VariantList();
274-
if (parameters != null) {
275-
foreach (Parameter p in parameters) {
276-
parameterNames.Add(p.Name);
277-
parameterValues.Add(Firebase.Variant.FromObject(p.Value));
278-
}
272+
StringList parameterNames = new StringList();
273+
VariantList parameterValues = new VariantList();
274+
if (parameters != null) {
275+
foreach (Parameter p in parameters) {
276+
parameterNames.Add(p.Name);
277+
parameterValues.Add(Firebase.Variant.FromObject(p.Value));
279278
}
280-
FirebaseAnalyticsInternal.SetDefaultEventParameters(parameterNames, parameterValues);
279+
}
280+
FirebaseAnalyticsInternal.SetDefaultEventParameters(parameterNames, parameterValues);
281281
}
282282

283283
/// Clears all analytics data for this app from the device and resets the app

analytics/src/swig/analytics.i

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ void LogEvent(const char* name, std::vector<std::string> parameter_names,
7878
delete[] parameters;
7979
}
8080

81-
// Internal version of SetDefaultEventParameters that teakes in two vectors of
82-
// of know types and converts them into C++ parameters to pass them along to
83-
// the public SetDefaulteventparameters
81+
// Internal version of SetDefaultEventParameters that takes in two vectors
82+
// of known types and converts them into C++ parameters to pass them along to
83+
// the public SetDefaultEventParameters
8484
void SetDefaultEventParameters(std::vector<std::string> parameter_names,
8585
std::vector<firebase::Variant> parameter_values) {
8686
if (parameter_names.size() != parameter_values.size()) {
@@ -91,10 +91,11 @@ void SetDefaultEventParameters(std::vector<std::string> parameter_names,
9191
}
9292
std::vector<Parameter> parameters;
9393

94-
for(size_t i = 0; i < parameter_names.size(); ++i) {
95-
parameters.push_back(Parameter(parameter_names[i].c_str(), parameter_values[i]));
96-
}
97-
SetDefaultEventParameters(parameters);
94+
for(size_t i = 0; i < parameter_names.size(); ++i) {
95+
parameters.push_back(Parameter(parameter_names[i].c_str(), parameter_values[i]));
96+
}
97+
98+
SetDefaultEventParameters(parameters);
9899
}
99100

100101
// Converts from a generic int, int map to the C++ Consent enums

docs/readme.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,10 @@ Release Notes
111111
-------------
112112
### Upcoming
113113
- Changes
114-
- Analytics: Added `SetDefaultEventParameters()` which allows developers to specify a dictionary of parameters that will be set on every event logged.
115-
- Analytics: `LogEvent()` now takes a vector of `Parameter` objects, instead of a pointer to an array and a count.
114+
- Analytics: Added `SetDefaultEventParameters()` which allows developers to
115+
specify a list of parameters that will be set on every event logged.
116+
- Analytics: `LogEvent()` now takes a vector of `Parameter` objects, instead
117+
of a pointer to an array and a count.
116118

117119
### 13.5.0
118120
- Changes

0 commit comments

Comments
 (0)