fix issue with init hosting prompts

CHANGELOG.md

@@ -1,3 +1,4 @@
 - Added `functions.list_functions` as a MCP tool (#9369)
 - Added AI Logic to `firebase init` CLI command and `firebase_init` MCP tool. (#9185)
 - Improved error messages for Firebase AI Logic provisioning during 'firebase init' (#9377)
+- Fixed issue where CLI fails to prompt for the public directory and set up Hosting files (#9403)

src/init/features/hosting/index.ts

@@ -36,7 +36,7 @@
 
 // TODO: come up with a better way to type this
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export async function askQuestions(setup: Setup, config: Config, options: Options): Promise<void> {
   setup.featureInfo = setup.featureInfo || {};
   setup.featureInfo.hosting = {};
 
@@ -68,10 +68,11 @@
     }
   }
 
+  let discoveredFramework = experiments.isEnabled("webframeworks")
+    ? await discover(config.projectDir, false)
+    : undefined;
+
   if (experiments.isEnabled("webframeworks")) {
-    let discoveredFramework = experiments.isEnabled("webframeworks")
-      ? await discover(config.projectDir, false)
-      : undefined;
     // First, if we're in a framework directory, ask to use that.
     if (
       discoveredFramework &&
@@ -90,54 +91,53 @@
         `Do you want to use a web framework? (${clc.bold("experimental")})`,
       );
     }
-    // If they say yes, ask for source directory if its not already known
-    if (setup.featureInfo.hosting.useWebFrameworks) {
-      setup.featureInfo.hosting.source ??= await input({
-        message: "What folder would you like to use for your web application's root directory?",
-        default: "hosting",
-      });
+  }
 
-      discoveredFramework = await discover(
-        join(config.projectDir, setup.featureInfo.hosting.source),
-      );
+  // If they say yes, ask for source directory if its not already known
+  if (setup.featureInfo.hosting.useWebFrameworks) {
+    setup.featureInfo.hosting.source ??= await input({
+      message: "What folder would you like to use for your web application's root directory?",
+      default: "hosting",
+    });
 
-      if (discoveredFramework) {
-        const name = WebFrameworks[discoveredFramework.framework].name;
-        setup.featureInfo.hosting.useDiscoveredFramework ??= await confirm({
-          message: `Detected an existing ${name} codebase in ${setup.featureInfo.hosting.source}, should we use this?`,
-          default: true,
-        });
-        if (setup.featureInfo.hosting.useDiscoveredFramework)
-          setup.featureInfo.hosting.webFramework = discoveredFramework.framework;
-      }
+    discoveredFramework = await discover(join(config.projectDir, setup.featureInfo.hosting.source));
 
-      // If it is not known already, ask what framework to use.
-      const choices: { name: string; value: string }[] = [];
-      for (const value in WebFrameworks) {
-        if (WebFrameworks[value]) {
-          const { name, init } = WebFrameworks[value];
-          if (init) choices.push({ name, value });
-        }
+    if (discoveredFramework) {
+      const name = WebFrameworks[discoveredFramework.framework].name;
+      setup.featureInfo.hosting.useDiscoveredFramework ??= await confirm({
+        message: `Detected an existing ${name} codebase in ${setup.featureInfo.hosting.source}, should we use this?`,
+        default: true,
+      });
+      if (setup.featureInfo.hosting.useDiscoveredFramework)
+        setup.featureInfo.hosting.webFramework = discoveredFramework.framework;
+    }
+
+    // If it is not known already, ask what framework to use.
+    const choices: { name: string; value: string }[] = [];
+    for (const value in WebFrameworks) {
+      if (WebFrameworks[value]) {
+        const { name, init } = WebFrameworks[value];
+        if (init) choices.push({ name, value });
       }
+    }
 
-      const defaultChoice = choices.find(
-        ({ value }) => value === discoveredFramework?.framework,
-      )?.value;
+    const defaultChoice = choices.find(
+      ({ value }) => value === discoveredFramework?.framework,
+    )?.value;
 
-      setup.featureInfo.hosting.webFramework ??= await select({
-        message: "Please choose the framework:",
-        default: defaultChoice,
-        choices,
-      });
+    setup.featureInfo.hosting.webFramework ??= await select({
+      message: "Please choose the framework:",
+      default: defaultChoice,
+      choices,
+    });
 
-      setup.featureInfo.hosting.region =
-        setup.featureInfo.hosting.region ||
-        (await select({
-          message: "In which region would you like to host server-side content, if applicable?",
-          default: DEFAULT_REGION,
-          choices: ALLOWED_SSR_REGIONS.filter((region) => region.recommended),
-        }));
-    }
+    setup.featureInfo.hosting.region =
+      setup.featureInfo.hosting.region ||
+      (await select({
+        message: "In which region would you like to host server-side content, if applicable?",
+        default: DEFAULT_REGION,
+        choices: ALLOWED_SSR_REGIONS.filter((region) => region.recommended),
+      }));
   } else {
     logger.info();
     logger.info(
@@ -157,15 +157,11 @@
       "Configure as a single-page app (rewrite all urls to /index.html)?",
     );
   }
-  // GitHub Action set up is still structured as doSetup
-  if (await confirm("Set up automatic builds and deploys with GitHub?")) {
-    return initGitHub(setup);
-  }
 }
 
 // TODO: come up with a better way to type this
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export async function actuate(setup: Setup, config: Config, options: Options): Promise<void> {
   const hostingInfo = setup.featureInfo?.hosting;
   if (!hostingInfo) {
     throw new FirebaseError(
@@ -186,7 +182,7 @@
       if (hostingInfo.source && existsSync(hostingInfo.source)) {
         rmSync(hostingInfo.source, { recursive: true });
       }
       await WebFrameworks[hostingInfo.webFramework].init!(setup, config);
     }
     setup.config.hosting = {
       source: hostingInfo.source,
@@ -207,7 +203,7 @@
     } else {
       // SPA doesn't need a 404 page since everything is index.html
       await config.askWriteProjectFile(
         `${hostingInfo.public}/404.html`,
         MISSING_TEMPLATE,
         !!options.force,
       );
@@ -216,9 +212,14 @@
     const c = new Client({ urlPrefix: "https://www.gstatic.com", auth: false });
     const response = await c.get<{ current: { version: string } }>("/firebasejs/releases.json");
     await config.askWriteProjectFile(
       `${hostingInfo.public}/index.html`,
       INDEX_TEMPLATE.replace(/{{VERSION}}/g, response.body.current.version),
       !!options.force,
     );
   }
+
+  // GitHub Action set up is still structured as doSetup
+  if (await confirm("Set up automatic builds and deploys with GitHub?")) {
+    return initGitHub(setup);
+  }
 }