Enable strict mode on all packages except firestore and database #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
Feiyang1,
alikn,
andirayo,
davideast,
dwoffinden,
hiranya911,
jamesdaniels,
jsdt,
mikelehen,
mmermerkaya,
pinarx,
ryanpbrewster,
schmidt-sebastian,
scottcrossen,
yuchenshi and
zijianjoy
as code owners
yuchenshi
approved these changes
Jul 8, 2019
Member
yuchenshi
left a comment
yuchenshi
left a comment
There was a problem hiding this comment.
Approval for testing. Thanks!
schmidt-sebastian
approved these changes
Jul 8, 2019
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
Approved for Firestore & RTDB & Storage
Feiyang1
approved these changes
Jul 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most packages have already had the flag enabled, this change enables it on the global
tsconfig.base.jsonand removes the flags on individualtsconfig.jsonfiles. Database is skipped because we have decided not to update it to strict mode, and Firestore will be updated soon.