fix(database): Adding toJSON() method to TransactionResult #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
suggested changes
Jul 25, 2017
|
|
||
| // Do not create public documentation. This is intended to make JSON serialization work but is otherwise unnecessary | ||
| // for end-users | ||
| toJSON(): any { |
Contributor
There was a problem hiding this comment.
We should really strive not to use "any". I think we can use "object" here.
mikelehen
approved these changes
Jul 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address https://stackoverflow.com/questions/43151022/cloud-functions-for-firebase-onwrite-timeout, this adds a toJSON method() in TransactionResult.
This also addresses Google-internal bug https://b.corp.google.com/issues/62262817 and allows transaction objects to be returned from GCF.