diff --git a/packages/auth/test/integration/webdriver/compat/firebaseui.test.ts b/packages/auth/test/integration/webdriver/compat/firebaseui.test.ts index 9a79a2a9edf..79fd3fca77b 100644 --- a/packages/auth/test/integration/webdriver/compat/firebaseui.test.ts +++ b/packages/auth/test/integration/webdriver/compat/firebaseui.test.ts @@ -51,11 +51,7 @@ browserDescribe('WebDriver integration with FirebaseUI', driver => { expect(snap.uid).to.be.a('string'); }); - it('allows google redirect sign in', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('allows google redirect sign in', async () => { const page = await startUi(); await page.clickGoogleSignIn(); const widget = new IdPPage(driver.webDriver); diff --git a/packages/auth/test/integration/webdriver/redirect.test.ts b/packages/auth/test/integration/webdriver/redirect.test.ts index 284c79aa6c0..4dbd4ea0665 100644 --- a/packages/auth/test/integration/webdriver/redirect.test.ts +++ b/packages/auth/test/integration/webdriver/redirect.test.ts @@ -48,11 +48,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { await driver.start('chrome'); }); - it('allows users to sign in', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('allows users to sign in', async () => { await driver.callNoWait(RedirectFunction.IDP_REDIRECT); const widget = new IdPPage(driver.webDriver); @@ -84,10 +80,6 @@ browserDescribe('WebDriver redirect IdP test', driver => { // Redirect works with middleware for now it('is blocked by middleware', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - if (driver.isCompatLayer()) { console.warn('Skipping middleware tests in compat'); this.skip(); @@ -114,11 +106,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { expect(await driver.getUserSnapshot()).to.be.null; }); - it('can link with another account account', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('can link with another account account', async () => { // First, sign in anonymously const { user: anonUser }: UserCredential = await driver.call( AnonFunction.SIGN_IN_ANONYMOUSLY @@ -140,11 +128,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { expect(user.email).to.eq('bob@bob.test'); }); - it('can be converted to a credential', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('can be converted to a credential', async () => { // Start with redirect await driver.callNoWait(RedirectFunction.IDP_REDIRECT); const widget = new IdPPage(driver.webDriver); @@ -172,11 +156,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { expect(second.providerData).to.eql(first.providerData); }); - it('handles account exists different credential errors', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('handles account exists different credential errors', async () => { // Start with redirect and a verified account await driver.callNoWait(RedirectFunction.IDP_REDIRECT); const widget = new IdPPage(driver.webDriver); @@ -211,11 +191,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { ]); }); - it('does not auto-upgrade anon accounts', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('does not auto-upgrade anon accounts', async () => { const { user: anonUser }: UserCredential = await driver.call( AnonFunction.SIGN_IN_ANONYMOUSLY ); @@ -232,11 +208,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { expect(curUser.uid).not.to.eq(anonUser.uid); }); - it('linking with anonymous user upgrades account', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('linking with anonymous user upgrades account', async () => { const { user: anonUser }: UserCredential = await driver.call( AnonFunction.SIGN_IN_ANONYMOUSLY ); @@ -254,11 +226,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { expect(curUser.isAnonymous).to.be.false; }); - it('is possible to link with different email', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('is possible to link with different email', async () => { const { user: emailUser }: UserCredential = await driver.call( EmailFunction.CREATE_USER, 'user@test.test' @@ -281,11 +249,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { expect(curUser.providerData.length).to.eq(2); }); - it('is possible to link with the same email', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('is possible to link with the same email', async () => { const { user: emailUser }: UserCredential = await driver.call( EmailFunction.CREATE_USER, 'same@test.test' @@ -327,11 +291,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { await driver.call(CoreFunction.SIGN_OUT); }); - it('a user can sign in again', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('a user can sign in again', async () => { // Sign in using pre-poulated user await driver.callNoWait(RedirectFunction.IDP_REDIRECT); @@ -347,11 +307,7 @@ browserDescribe('WebDriver redirect IdP test', driver => { expect(user.email).to.eq(user1.email); }); - it('reauthenticate works for the correct user', async function () { - // Test is ignored for now as it fails. - // TODO: Investigate and unskip the test. - this.skip(); - + it('reauthenticate works for the correct user', async () => { // Sign in using pre-poulated user await driver.callNoWait(RedirectFunction.IDP_REDIRECT); diff --git a/packages/auth/test/integration/webdriver/util/test_server.ts b/packages/auth/test/integration/webdriver/util/test_server.ts index 0c76e680d0e..9702c450135 100644 --- a/packages/auth/test/integration/webdriver/util/test_server.ts +++ b/packages/auth/test/integration/webdriver/util/test_server.ts @@ -39,7 +39,11 @@ class AuthTestServer { } get address(): string { - return `http://localhost:${PORT_NUMBER}`; + /* + We use "127.0.0.1" rather than "localhost" since emulator uses the former, + and we want to be on the same origin (to access session storage for redirect-based tests). + */ + return `http://127.0.0.1:${PORT_NUMBER}`; } async start(): Promise {