refactor(database): Add 'noImplicitAny' support

Adds support for the 'noImplicitAny' Typescript compiler option to the database implementation.

Author: jsayol

src/database/api/Query.ts

@@ -22,6 +22,10 @@ import { DataSnapshot } from './DataSnapshot';
 
 let __referenceConstructor: new(repo: Repo, path: Path) => Query;
 
+export interface SnapshotCallback {
+  (a: DataSnapshot, b?: string): any
+}
+
 /**
  * A Query represents a filter to be applied to a firebase location.  This object purely represents the
  * query expression (and exposes our public API to build the query).  The actual query logic is in ViewBase.js.
@@ -143,8 +147,8 @@ export class Query {
    * @param {Object=} context
    * @return {!function(DataSnapshot, string=)}
    */
-  on(eventType: string, callback: (a: DataSnapshot, b?: string) => any,
-     cancelCallbackOrContext?: ((a: Error) => any) | Object, context?: Object): (a: DataSnapshot, b?: string) => any {
+  on(eventType: string, callback: SnapshotCallback,
+     cancelCallbackOrContext?: ((a: Error) => any) | Object, context?: Object): SnapshotCallback {
     validateArgCount('Query.on', 2, 4, arguments.length);
     validateEventType('Query.on', 1, eventType, false);
     validateCallback('Query.on', 2, callback, false);
@@ -178,7 +182,7 @@ export class Query {
    * @param {?Object} context
    * @protected
    */
-  onChildEvent(callbacks: { [k: string]: (a: DataSnapshot, b: string | null) => any },
+  onChildEvent(callbacks: { [k: string]: SnapshotCallback },
                cancelCallback: ((a: Error) => any) | null, context: Object | null) {
     const container = new ChildEventRegistration(callbacks, cancelCallback, context);
     this.repo.addEventCallbackForQuery(this, container);
@@ -189,7 +193,7 @@ export class Query {
    * @param {(function(!DataSnapshot, ?string=))=} callback
    * @param {Object=} context
    */
-  off(eventType?: string, callback?: (a: DataSnapshot, b?: string | null) => any, context?: Object) {
+  off(eventType?: string, callback?: SnapshotCallback, context?: Object) {
     validateArgCount('Query.off', 0, 3, arguments.length);
     validateEventType('Query.off', 1, eventType, true);
     validateCallback('Query.off', 2, callback, true);
@@ -218,10 +222,8 @@ export class Query {
    * @param context
    * @return {!firebase.Promise}
    */
-  once(eventType: string, 
-       userCallback?: (a: DataSnapshot, b?: string) => any,
-       cancelOrContext?, 
-       context?: Object): Promise<DataSnapshot> {
+  once(eventType: string, userCallback?: SnapshotCallback,
+       cancelOrContext?: ((a: Error) => void) | Object, context?: Object): Promise<DataSnapshot> {
     validateArgCount('Query.once', 1, 4, arguments.length);
     validateEventType('Query.once', 1, eventType, false);
     validateCallback('Query.once', 2, userCallback, true);
@@ -379,7 +381,7 @@ export class Query {
     }
 
     // Calling with no params tells us to start at the beginning.
-    if (value == null) {
+    if (value === undefined) {
       value = null;
       name = null;
     }

src/database/core/SyncTree.ts

@@ -521,7 +521,7 @@ export class SyncTree {
           let queries: Query[] = [];
           if (maybeChildSyncPoint) {
             queries = queries.concat(
-                maybeChildSyncPoint.getQueryViews().map(view=> view.getQuery())
+              maybeChildSyncPoint.getQueryViews().map(view=> view.getQuery())
             );
           }
           forEach(childMap, function (key: string, childQueries: Query[]) {

src/database/core/snap/ChildrenNode.ts

@@ -186,7 +186,7 @@ export class ChildrenNode implements Node {
       // convert to array.
       const array: Object[] = [];
       for (let key in obj)
-        array[key as any as number] = obj[key];
+        array[<number><any>key as any as number] = obj[key];
 
       return array;
     } else {

src/database/core/snap/childSet.ts

@@ -64,15 +64,15 @@ export const buildChildSet = function<K,V>(childList: NamedNode[],
       return null;
     } else if (length == 1) {
       namedNode = childList[low];
-      key = keyFn ? keyFn(namedNode) : namedNode as any as K;
-      return new LLRBNode(key, namedNode.node as any as V, LLRBNode.BLACK, null, null);
+      key = keyFn ? keyFn(namedNode) : <K><any>namedNode as any as K;
+      return new LLRBNode(key, <V><any>namedNode.node as any as V, LLRBNode.BLACK, null, null);
     } else {
       const middle = parseInt((length / 2 as any), 10) + low;
       const left = buildBalancedTree(low, middle);
       const right = buildBalancedTree(middle + 1, high);
       namedNode = childList[middle];
-      key = keyFn ? keyFn(namedNode) : namedNode as any as K;
-      return new LLRBNode(key, namedNode.node as any as V, LLRBNode.BLACK, left, right);
+      key = keyFn ? keyFn(namedNode) : <K><any>namedNode as any as K;
+      return new LLRBNode(key, <V><any>namedNode.node as any as V, LLRBNode.BLACK, left, right);
     }
   };
 
@@ -87,8 +87,8 @@ export const buildChildSet = function<K,V>(childList: NamedNode[],
       index -= chunkSize;
       const childTree = buildBalancedTree(low + 1, high);
       const namedNode = childList[low];
-      const key: K = keyFn ? keyFn(namedNode) : namedNode as any as K;
-      attachPennant(new LLRBNode(key, namedNode.node as any as V, color, null, childTree));
+      const key: K = keyFn ? keyFn(namedNode) : <K><any>namedNode as any as K;
+      attachPennant(new LLRBNode(key, <V><any>namedNode.node as any as V, color, null, childTree));
     };
 
     const attachPennant = function (pennant: LLRBNode<K, V>) {

src/database/core/util/util.ts

@@ -240,9 +240,9 @@ export const warnAboutUnsupportedMethod = function (methodName: string) {
  */
 export const isInvalidJSONNumber = function (data: any): boolean {
   return typeof data === 'number' &&
-      (data != data || // NaN
-       data == Number.POSITIVE_INFINITY ||
-       data == Number.NEGATIVE_INFINITY);
+    (data != data || // NaN
+    data == Number.POSITIVE_INFINITY ||
+    data == Number.NEGATIVE_INFINITY);
 };
 
 

src/database/core/view/ChildChangeAccumulator.ts

@@ -18,7 +18,7 @@ export class ChildChangeAccumulator {
       type == Change.CHILD_CHANGED ||
       type == Change.CHILD_REMOVED, 'Only child changes supported for tracking');
     assert(childKey !== '.priority', 'Only non-priority child changes can be tracked.');
-    const oldChange = safeGet(this.changeMap_, childKey) as Change;
+    const oldChange = <Change>safeGet(this.changeMap_, childKey) as Change;
     if (oldChange) {
       const oldType = oldChange.type;
       if (type == Change.CHILD_ADDED && oldType == Change.CHILD_REMOVED) {

src/database/realtime/Connection.ts

@@ -199,7 +199,7 @@ export class Connection {
 
   private onSecondaryControl_(controlData: { [k: string]: any }) {
     if (MESSAGE_TYPE in controlData) {
-      const cmd: string = controlData[MESSAGE_TYPE] as string;
+      const cmd = <string>controlData[MESSAGE_TYPE] as string;
       if (cmd === SWITCH_ACK) {
         this.upgradeIfSecondaryHealthy_();
       } else if (cmd === CONTROL_RESET) {
@@ -292,7 +292,7 @@ export class Connection {
   private onControl_(controlData: { [k: string]: any }) {
     const cmd: string = requireKey(MESSAGE_TYPE, controlData);
     if (MESSAGE_DATA in controlData) {
-      const payload: any = controlData[MESSAGE_DATA];
+      const payload = controlData[MESSAGE_DATA];
       if (cmd === SERVER_HELLO) {
         this.onHandshake_(payload);
       } else if (cmd === END_TRANSMISSION) {

src/database/realtime/Transport.ts

@@ -53,7 +53,7 @@ export abstract class Transport {
 
   abstract markConnectionHealthy(): void;
 
-  abstract markConnectionHealthy();
+  abstract markConnectionHealthy(): void;
 }
 
 export interface TransportConstructor {

src/database/realtime/TransportManager.ts

@@ -51,7 +51,7 @@ export class TransportManager {
     if (isSkipPollConnection) {
       this.transports_ = [WebSocketConnection];
     } else {
-      const transports = this.transports_ = [] as TransportConstructor[];
+      const transports = this.transports_ = <TransportConstructor[]>[] as TransportConstructor[];
       each(TransportManager.ALL_TRANSPORTS, (i: number, transport: TransportConstructor) => {
         if (transport && transport['isAvailable']()) {
           transports.push(transport);

src/database/realtime/WebSocketConnection.ts

@@ -273,7 +273,7 @@ export class WebSocketConnection implements Transport {
   handleIncomingFrame(mess: { [k: string]: any }) {
     if (this.mySock === null)
       return; // Chrome apparently delivers incoming packets even after we .close() the connection sometimes.
-    const data: string = mess['data'] as string;
+    const data = <string>mess['data'] as string;
     this.bytesReceived += data.length;
     this.stats_.incrementCounter('bytes_received', data.length);