address comments #2

Author: wu-hui

packages/firestore/src/util/async_queue.ts

@@ -226,6 +226,7 @@ export class AsyncQueue {
     op: () => Promise<T>
   ): void {
     this.verifyNotFailed();
+    // tslint:disable-next-line:no-floating-promises
     this.enqueueInternal(op);
   }
 

packages/firestore/test/integration/api/database.test.ts

@@ -31,6 +31,7 @@ import {
   apiDescribe,
   arrayContainsAnyOp,
   inOp,
+  shutdownDb,
   withTestCollection,
   withTestDb,
   withTestDbs,
@@ -1073,7 +1074,7 @@ apiDescribe('Database', (persistence: boolean) => {
   it('can start a new instance after shut down', async () => {
     return withTestDoc(persistence, async docRef => {
       const firestore = docRef.firestore;
-      await (firestore as any)._shutdown();
+      await shutdownDb(firestore);
 
       const newFirestore = firebase.firestore!(firestore.app);
       expect(newFirestore).to.not.equal(firestore);
@@ -1092,14 +1093,15 @@ apiDescribe('Database', (persistence: boolean) => {
       const app = docRef.firestore.app;
       await app.delete();
 
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       expect((docRef.firestore as any)._isShutdown).to.be.true;
     });
   });
 
   it('new operation after shutdown should throw', async () => {
     await withTestDoc(persistence, async docRef => {
       const firestore = docRef.firestore;
-      await (firestore as any)._shutdown();
+      await shutdownDb(firestore);
 
       expect(() => {
         firestore.doc(docRef.path).set({ foo: 'bar' });
@@ -1110,8 +1112,8 @@ apiDescribe('Database', (persistence: boolean) => {
   it('calling shutdown mutiple times should proceed', async () => {
     await withTestDoc(persistence, async docRef => {
       const firestore = docRef.firestore;
-      await (firestore as any)._shutdown();
-      await (firestore as any)._shutdown();
+      await shutdownDb(firestore);
+      await shutdownDb(firestore);
 
       expect(() => {
         firestore.doc(docRef.path).set({ foo: 'bar' });

packages/firestore/test/integration/util/helpers.ts

@@ -303,6 +303,11 @@ function wipeDb(db: firestore.FirebaseFirestore): Promise<void> {
   return Promise.resolve(undefined);
 }
 
+export function shutdownDb(db: firestore.FirebaseFirestore): Promise<void> {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  return (db as any)._shutdown();
+}
+
 // TODO(in-queries): This exists just so we don't have to do the cast
 // repeatedly. Once we expose 'array-contains-any' publicly we can remove it and
 // just use 'array-contains-any' in all the tests.