Skip to content

Remove iOS 11.4 from FTL list. #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonsimantov merged 1 commit into from
Jun 3, 2022
Merged

Remove iOS 11.4 from FTL list. #982

jonsimantov merged 1 commit into from
Jun 3, 2022

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jun 3, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

iOS 11.4 was deprecated in Test Lab and has now been removed.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov requested a review from sunmou99 June 3, 2022 17:14
@jonsimantov jonsimantov enabled auto-merge (squash) June 3, 2022 17:18
sunmou99
sunmou99 reviewed Jun 3, 2022
View reviewed changes
scripts/gha/print_matrix_configuration.py
"emulator_32bit": {"type": "virtual", "image":"system-images;android-30;google_apis;x86"},
"ios_min": {"type": "real", "model":"iphone8", "version":"11.4"},
"ios_target": {"type": "real", "model":"iphone8plus", "version":"12.0"},
"ios_min": {"type": "real", "model":"iphone8", "version":"12.4"},
Copy link
Contributor

@sunmou99 sunmou99 Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12.4 is with TAG deprecated:
gcloud firebase test ios models list

I would suggest update all iOS devices to: 13.2, 14.7, 15.4
I also checked android devices, looks good for now.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jun 3, 2022
@dconeybe dconeybe mentioned this pull request Jun 3, 2022
Closed
@jonsimantov jonsimantov merged commit f918b73 into main Jun 3, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit f918b73
Last updated: Fri Jun 3 14:06 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 3, 2022
@firebase firebase locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsimantov @sunmou99