PR Followup (#1237)

* Firestore COUNT API (#1174)

* Firestore COUNT API

* Exempt from go/allstar check (#1173)

* Token-changed listeners for iOS AppCheck (#1172)

* [macOS sandbox mode] Application group name mangling for semaphores (#1167)

When macOS Sandbox mode is enabled, macOS requires that semaphores have a name that is prefixed by the App's Group Name. If the semaphore's name doesn't match this convention then its creation fails.

Unfortunately there's no official way for the SDK to query the app's group name at runtime, so we can't automatically mangle the semaphore names.

Instead I've updated the SDK to use an Info.plist property named FBAppGroupEntitlementName on macOS. If that property is present then the SDK will use it's value to prefix the semaphore names.

As an additional issue, the SDK attempted to detect semaphore creation errors by comparing the semaphore handle to nil. But in the case of macOS, a semaphore creation error returns SEM_FAILED which is 0xFFFFFFFFFFFFFFFF, not nil. And on Linux, sem_init returns -1. I've updated the corresponding platform implementations to detect the correct  values for these errors.

* Setup Desktop test workflow that detects C++ SDK breakage caused by iOS SDK changes (#1162)

* [Bugfx] Fix Nightly Test Report template (#1181)

* Reduce number of RewardedAd loads on iOS in CI (#1180)

The GMA backend doesn't whitelist iOS devices running in CI which means number of ads that can be served to iOS in CI is restricted. This is true even when using the prescribed Demo Ad Unit Id.

This PR reduces the number of ads we load on iOS in an attempt to minimize the chance of encountering NoFillErrors and push our CI to green.

* Firestore COUNT implementation (WIP)

* Firestore COUNT implementation (WIP)

* Fix linting

* Fix linting

* Fix linking

* Cleanup

* Fix release notes

* Format

* Fixes from review

* Formatting

* Responding to PR comments.

* Add Hash

* Add Hash

* Fix copyright year

* Rename

* Format

* Rename

* Fixup constructor/assignment parameter naming.

* Format

---------

Co-authored-by: chkuang-g <[email protected]>
Co-authored-by: Matthew Hyndman <[email protected]>
Co-authored-by: DellaBitta <[email protected]>
Co-authored-by: Mou Sun <[email protected]>

* Tomandersen/count test (#1206)

* Fix linking

* Cleanup

* Responding to PR comments.

* Rename

* Rename

* Fixup constructor/assignment parameter naming.

* Add Test

* Format

* Add test

* Add test

* Format

* Recognize NaN filter probelm

* Add tests

* Add tests

* Add tests

* Test is_valid()

* Add constructor and assignment tests.

* Rename variable

* Format

* Remove extra semicolon

* Add self move assignment test

* Format

* Simplify

* Pretty

---------

Co-authored-by: chkuang-g <[email protected]>
Co-authored-by: Matthew Hyndman <[email protected]>
Co-authored-by: DellaBitta <[email protected]>
Co-authored-by: Mou Sun <[email protected]>

Author: 5 people

firestore/integration_test_internal/src/aggregate_query_snapshot_test.cc

@@ -135,7 +135,7 @@ TEST_F(
   EXPECT_EQ(snapshot_copy_dest.query(), AggregateQuery());
   EXPECT_FALSE(snapshot_copy_dest.is_valid());
 
-  snapshot_copy_dest;
+  snapshot_copy_dest = snapshot;
 
   EXPECT_EQ(snapshot_copy_dest.count(), 0);
   EXPECT_EQ(snapshot_copy_dest.query(), AggregateQuery());

firestore/integration_test_internal/src/aggregate_query_test.cc

@@ -104,7 +104,7 @@ TEST_F(
   EXPECT_EQ(copied_aggregate_query.query(), Query());
   EXPECT_FALSE(copied_aggregate_query.is_valid());
 
-  copied_aggregate_query;
+  copied_aggregate_query = aggregate_query;
 
   EXPECT_EQ(aggregate_query.query(), Query());
   EXPECT_FALSE(aggregate_query.is_valid());
@@ -160,7 +160,6 @@ TEST_F(AggregateQueryTest,
 
 TEST_F(AggregateQueryTest, CopyAssignmentAppliedSelfReturnsEqualObject) {
   const Query query = TestFirestore()->Collection("foo").Limit(10);
-
   AggregateQuery aggregate_query = query.Count();
 
   EXPECT_EQ(aggregate_query.query(), query);