Skip to content

Firebase ML changed endpoint #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Firebase ML changed endpoint #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/machine-learning/machine-learning-api-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import * as utils from '../utils/index';
import * as validator from '../utils/validator';
import { FirebaseApp } from '../firebase-app';

const ML_V1BETA1_API = 'https://mlkit.googleapis.com/v1beta1';
const ML_V1BETA2_API = 'https://firebaseml.googleapis.com/v1beta2';
const FIREBASE_VERSION_HEADER = {
'X-Firebase-Client': 'fire-admin-node/<XXX_SDK_VERSION_XXX>',
};
Expand Down Expand Up @@ -253,7 +253,7 @@ export class MachineLearningApiClient {
private getUrl(): Promise<string> {
return this.getProjectIdPrefix()
.then((projectIdPrefix) => {
return `${ML_V1BETA1_API}/${this.projectIdPrefix}`;
return `${ML_V1BETA2_API}/${this.projectIdPrefix}`;
});
}

Expand Down
2 changes: 1 addition & 1 deletion test/unit/machine-learning/machine-learning-api-client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const expect = chai.expect;

describe('MachineLearningApiClient', () => {

const BASE_URL = 'https://mlkit.googleapis.com/v1beta1';
const BASE_URL = 'https://firebaseml.googleapis.com/v1beta2';

const MODEL_ID = '1234567';
const MODEL_RESPONSE = {
Expand Down