fix: Removing FirebaseServiceInterface and FirebaseServiceInternalsInterface #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojeil-google
approved these changes
Jan 8, 2021
bojeil-google
approved these changes
Jan 8, 2021
BorntraegerMarc
pushed a commit
to BorntraegerMarc/firebase-admin-node
that referenced
this pull request
Jan 28, 2021
…terface (firebase#1128) * fix: Removing FirebaseService and FirebaseServiceInterface internal APIs * chore: Added unit tests for service caching behavior * fix: Using equal instead of deep.equal for reference tests
This was referenced Mar 12, 2021
This was referenced Jun 2, 2024
This was referenced Jun 19, 2024
This was referenced Jul 17, 2024
This was referenced Jul 27, 2024
This was referenced Aug 10, 2024
This was referenced Aug 17, 2024
This was referenced Aug 28, 2024
This was referenced Sep 5, 2024
This was referenced Sep 24, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards modularization I'm removing the above 2 internal interfaces. Classes like
AuthandRemoteConfigwill no longer have to explicitly implementFirebaseServiceInterfaceor implement a placeholder "Internals" class to support state tear down at app delete. Classes likeDatabaseServicethat has internal state that should be cleaned up can simply implement adelete()method. TheFirebaseAppclass will look for this method and call it if available during app delete.At the same time I'm also removing some old, unused code for registering (via monkey patch) services with
FirebaseNamespaceand calling app hooks. Both these functions haven't been used for quite some time, and now that we are looking at modularization, they won't be useful in the future either.