fix: ApiClientUtils.getDefaultTransport() should return a cached instance to an ApacheHttp2Transport (#1059)

* fix: `ApiClientUtils.getDefaultTransport()` should return cached instance to an `ApacheHttp2Transport`

* fix: lint

* reduce timeout time

* fix: use new transport to trigger writeTimeout

Author: jonathanedey

src/main/java/com/google/firebase/internal/ApiClientUtils.java

@@ -88,6 +88,10 @@ public static JsonFactory getDefaultJsonFactory() {
   }
 
   public static HttpTransport getDefaultTransport() {
-    return new ApacheHttp2Transport();
+    return TransportInstanceHolder.INSTANCE;
+  }
+
+  private static class TransportInstanceHolder {
+    static final HttpTransport INSTANCE = new ApacheHttp2Transport();
   }
 }

src/test/java/com/google/firebase/internal/ApacheHttp2TransportIT.java

@@ -198,9 +198,12 @@ public void testReadTimeoutAuthorizedPost() throws FirebaseException {
 
   @Test(timeout = 10_000L)
   public void testWriteTimeoutAuthorizedGet() throws FirebaseException {
+    // Use a fresh transport so that writeTimeout triggers while waiting for the transport to
+    // be ready to receive data.
     app = FirebaseApp.initializeApp(FirebaseOptions.builder()
         .setCredentials(MOCK_CREDENTIALS)
         .setWriteTimeout(100)
+        .setHttpTransport(new ApacheHttp2Transport())
         .build(), "test-app");
     ErrorHandlingHttpClient<FirebaseException> httpClient = getHttpClient(true, app);
     HttpRequestInfo request = HttpRequestInfo.buildGetRequest(GET_URL);
@@ -217,9 +220,12 @@ public void testWriteTimeoutAuthorizedGet() throws FirebaseException {
 
   @Test(timeout = 10_000L)
   public void testWriteTimeoutAuthorizedPost() throws FirebaseException {
+    // Use a fresh transport so that writeTimeout triggers while waiting for the transport to
+    // be ready to receive data.
     app = FirebaseApp.initializeApp(FirebaseOptions.builder()
         .setCredentials(MOCK_CREDENTIALS)
         .setWriteTimeout(100)
+        .setHttpTransport(new ApacheHttp2Transport())
         .build(), "test-app");
     ErrorHandlingHttpClient<FirebaseException> httpClient = getHttpClient(true, app);
     HttpRequestInfo request = HttpRequestInfo.buildJsonPostRequest(POST_URL, payload);
@@ -292,6 +298,21 @@ public void testVerifyProxyIsRespected() {
     }
   }
 
+  @Test
+  public void testVerifyDefaultTransportReused() {
+    FirebaseOptions o1 = FirebaseOptions.builder()
+        .setCredentials(MOCK_CREDENTIALS)
+        .build();
+    
+    FirebaseOptions o2 = FirebaseOptions.builder()
+        .setCredentials(MOCK_CREDENTIALS)
+        .build();
+
+    HttpTransport t1 = o1.getHttpTransport();
+    HttpTransport t2 = o2.getHttpTransport();
+    assertEquals(t1, t2);
+  }
+
   private static ErrorHandlingHttpClient<FirebaseException> getHttpClient(boolean authorized,
       FirebaseApp app) {
     HttpRequestFactory requestFactory;

src/test/java/com/google/firebase/internal/ApiClientUtilsTest.java

@@ -25,6 +25,7 @@
 import com.google.api.client.http.HttpRequest;
 import com.google.api.client.http.HttpRequestFactory;
 import com.google.api.client.http.HttpResponse;
+import com.google.api.client.http.HttpTransport;
 import com.google.api.client.http.HttpUnsuccessfulResponseHandler;
 import com.google.api.client.testing.http.MockHttpTransport;
 import com.google.api.client.testing.http.MockLowLevelHttpResponse;
@@ -128,4 +129,12 @@ public void disconnect() throws IOException {
 
     assertTrue(lowLevelResponse.isDisconnected());
   }
+
+  @Test
+  public void testVerifyDefaultTransportReused() {
+    HttpTransport t1 = ApiClientUtils.getDefaultTransport();
+    HttpTransport t2 = ApiClientUtils.getDefaultTransport();
+    assertEquals(t1, t2);
+  }
+
 }