Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when adding the github action #1

Closed
kostyantyn opened this issue Aug 14, 2024 · 5 comments
Closed

Error when adding the github action #1

kostyantyn opened this issue Aug 14, 2024 · 5 comments

Comments

@kostyantyn
Copy link

Hi,

Thanks for working on such a nice linter!

While testing it, I see errors:

Run fionn/newline-linter@master
Run /home/ubuntu/_work/_actions/fionn/newline-linter/master/git-no-newlines
/__w/_temp/15db5329-070c-4c56-87fe-72c0a6f8d2b4.sh: line 1: /home/ubuntu/_work/_actions/fionn/newline-linter/master/git-no-newlines: No such file or directory
Error: Process completed with exit code 127.

Config is the following:

    - name: Check newlines
      uses: fionn/newline-linter@master
      with:
        exclusion_pattern: vendor

Any hints as to why it doesn't work out of the box?

@fionn
Copy link
Owner

fionn commented Aug 15, 2024

Hi, I am glad you like the linter (even though the action is broken for you).

Are you running in a container on a self-hosted runner? If so, then I think I know what the problem is and will create a branch for you to test.

If not, can you share a complete minimal workflow file so I can try to reproduce it?

@kostyantyn
Copy link
Author

Hi @fionn . Indeed, I run self-hosted runner.

@fionn
Copy link
Owner

fionn commented Aug 16, 2024

Could you point it at self-hosted-container or 8752156 and try again?

@kostyantyn
Copy link
Author

Amazing! works like a charm!

cmd/tracer/internal/handlers/decoder/index.html: no newline at end of file
Error: No newline at end of file.
Error: Process completed with exit code 31.

This Github action is such a PR-review productivity booster!

@fionn fionn closed this as completed in 8752156 Aug 16, 2024
@fionn
Copy link
Owner

fionn commented Aug 16, 2024

Great! And I'm very happy it's getting some use outside of my work repos. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants